This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Development - v1.0.0 (aka PM4 rewrite) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Namespace changed to JaxkDev/KOTH - PSR-4 now used. - File header reduced, end year removed, discord tag corrected. - Removed YAML - Added PHPStan/PMMP to composer dev requirements.
- 500+ PHPStan issues resolved. - Loads of mess cut out too.
- Take note of permissions changes here.
- Also green on PHPStan L5 - Minor things still need to be changed.
JaxkDev
added
Priority: High
From 1k problems to 0 in a day :)
- Saved when changed to reduce conflicts during runtime editing.
- King text particle shows lobby info when not 'started' - start now respects the min player's requirement. - forcestart ignores min player's. - players are now immobile while waiting for arena to start.
|
Best I can do by myself with regards to testing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending testing.