Hacks for OpenSWE1R compilation #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
commented
Nov 9, 2018
| #define PRIX32 "X" | ||
| #define PRIX16 "X" | ||
| #define PRIX8 "X" | ||
| #define PRIu64 "L" |
There was a problem hiding this comment.
This is a hack that's understood by our printf implementations
Other instances too
|
Everything fixed upstream. Remains opened until confirmed that OpenSWE1R still "works". |
JayFoxRox
added
the
collection
JayFoxRox
added
the
needs-testing
|
Confirmed it still works with latest nxdk master. Well.. still runs out of memory and still looks like garbage due to lack of textures. - but it's not nxdk's fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used with JayFoxRox/openswe1r#43 (which includes more libc stuff that wasn't moved to nxdk)