Rework audio #16
Open
Rework audio #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFoxRox
force-pushed
the
audio-fixes
branch
from
12028ff
to
6b7bf14
Compare
JayFoxRox
commented
Dec 22, 2017
com/a3d.c
Outdated
| API(A3D_DISABLE_SPLASHSCREEN) = 0x00000080, | ||
| API(A3D_REVERB) = 0x00000100, | ||
| API(A3D_GEOMETRIC_REVERB) = 0x00000200, | ||
| API(A3D_DISABLE_FOCUS_MUTE) = 0x00000400 |
JayFoxRox
force-pushed
the
audio-fixes
branch
from
6b7bf14
to
7e8b8f1
Compare
|
|
JayFoxRox
commented
Jan 1, 2018
| API(A3DSTATUS_BUFFERLOST) = 0x00000002, | ||
| API(A3DSTATUS_LOOPING) = 0x00000004, | ||
| API(A3DSTATUS_WAITING_FOR_FLUSH) = 0x00001000 | ||
| }; |
JayFoxRox
commented
Jan 1, 2018
| API(DWORD) dwMaxSampleRate; | ||
| API(DWORD) dwMax2DBuffers; | ||
| API(DWORD) dwMax3DBuffers; | ||
| } API(A3DCAPS_HARDWARE); |
JayFoxRox
commented
Jan 1, 2018
| API(WAVEFORMATEX) fmt; | ||
| Address data; | ||
| uint32_t event_offset; | ||
| uint32_t event_handle; | ||
| } A3DSOURCE; |
JayFoxRox
commented
Jan 1, 2018
| API(A3D_REVERB) = 0x00000100, | ||
| API(A3D_GEOMETRIC_REVERB) = 0x00000200, | ||
| API(A3D_DISABLE_FOCUS_MUTE) = 0x00000400 | ||
| }; |
JayFoxRox
commented
Jan 2, 2018
| printf("AL_SOFT_deferred_updates not present, using fallback\n"); | ||
| } | ||
|
|
||
| // Stop updating, so we must force IA3d4::Flush |
JayFoxRox
commented
Jan 2, 2018
| _DeferUpdatesSOFT = alc_DeferUpdatesSOFT; | ||
| _ProcessUpdatesSOFT = alc_ProcessUpdatesSOFT; | ||
| printf("AL_SOFT_deferred_updates not present, using fallback\n"); | ||
| } |
There was a problem hiding this comment.
assert that the functionpointers have been set now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I attempted to add some more audio functionality and I (mostly) failed hard.
Somehow gain values are too low, audio still doesn't pause during menu and various other bugs exist.
Fortunately the audio subsytem can be deactivated in the options, so this is not too critical.
DuplicateSourceis absolutely horrible. It should - to my understanding - copy all flags). However this is still a lot better than what's in master currently. I'll create a new issue about this after merge.It also doesn't differentiate between native and 3D sources, which is another big issue.
SetPanValuestherefore can't be implemented.Also missing
SetEq, Doppler stuff and the big one: audio streaming.FIXME: