Adding option to prepend cover to TOC #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzCore
added a commit
that referenced
this pull request
Sep 6, 2016
JazzCore
added a commit
that referenced
this pull request
Sep 6, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23, @signalkraft proposed to always prepend cover to TOC by switching the order of the command line arguments.
This is, IMHO, the right thing to do, but it would change pdfkit's previous behavior. This PR adds to each API one more parameter that lets you choose which one you want to go first between cover and TOC.
The new parameter,
cover_first, will default toFalse, so the default behavior will stay exactly the same.