Skip to content
This repository has been archived by the owner on Feb 21, 2021. It is now read-only.

[issue #879] moved all installations to /opt/jderobot #880

Merged
merged 9 commits into from
Jul 27, 2017

Conversation

aitormf
Copy link
Collaborator

@aitormf aitormf commented Jul 17, 2017

Moved all installations to /opt/jderobot

now we need use following source commad instead of gazebo-setup:

source /opt/jderobot/soruce.bash

Is needed try all components, in particular VisualStates (@reysam93) and ardrone_driver because These components have hardcoded paths and I had to modify the code.

visualStates installation is now done using cmakelists instead of setup.sh script

@fqez and @chanfr, can you verify this PR?

This PR fix #879 and #872

CMakeLists.txt Outdated
@@ -157,6 +165,9 @@ INSTALL(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/Deps DESTINATION ${CMAKE_INSTALL_P
# Install ROS Launch files
INSTALL(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/scripts/launch DESTINATION ${CMAKE_INSTALL_PREFIX}/share/jderobot)

# Install setup.bash
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/setup.bash DESTINATION ${CMAKE_INSTALL_PREFIX}/share/jderobot)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be just ${CMAKE_INSTALL_PREFIX}

…libs instead of /opt/jderobot/libs/jderobot/
Copy link
Contributor

@reysam93 reysam93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In file visualStates.cpp, the line 150 should be changed from:
system("/usr/local/bin/getinterfaces.sh /usr/local/include/jderobot/slice > /tmp/allinterfaces.txt");
to:
system("/usr/local/bin/getinterfaces.sh /opt/jderobot/include/jderobot/slice > /tmp/allinterfaces.txt");

The rest is ok

@aitormf
Copy link
Collaborator Author

aitormf commented Jul 25, 2017

@reysam93 updated this line, thanks

Copy link
Member

@chanfr chanfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

Copy link
Member

@lr-morales lr-morales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting CMAKE_INSTALL_PREFIX in this way could lock installation to /opt/jderobot, ignoring command line requests via -DCMAKE_INSTALL_PREFIX or cache values (breaking more in turn #485).
Checked in a Xenial lxc containter forcing variable output and checking cache values.
I'm looking for an alternative regarding this issue .

@lr-morales
Copy link
Member

@aitormf Please check your PR branch for a possible solution for the lock problem.

[issue JdeRobot#485] Set CMAKE_INSTALL_PREFIX only if default value is requested
@aitormf
Copy link
Collaborator Author

aitormf commented Jul 27, 2017

Thanks @lr-morales for the solution

@fqez fqez merged commit 8d8f928 into JdeRobot:master Jul 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[installation] move all install to /opt/jderobot
5 participants