[issue #879] moved all installations to /opt/jderobot #880
Conversation
CMakeLists.txt
Outdated
| @@ -157,6 +165,9 @@ INSTALL(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/Deps DESTINATION ${CMAKE_INSTALL_P | |||
| # Install ROS Launch files | |||
| INSTALL(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/scripts/launch DESTINATION ${CMAKE_INSTALL_PREFIX}/share/jderobot) | |||
|
|
|||
| # Install setup.bash | |||
| INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/setup.bash DESTINATION ${CMAKE_INSTALL_PREFIX}/share/jderobot) | |||
There was a problem hiding this comment.
This one should be just ${CMAKE_INSTALL_PREFIX}
…libs instead of /opt/jderobot/libs/jderobot/
There was a problem hiding this comment.
In file visualStates.cpp, the line 150 should be changed from:
system("/usr/local/bin/getinterfaces.sh /usr/local/include/jderobot/slice > /tmp/allinterfaces.txt");
to:
system("/usr/local/bin/getinterfaces.sh /opt/jderobot/include/jderobot/slice > /tmp/allinterfaces.txt");
The rest is ok
|
@reysam93 updated this line, thanks |
There was a problem hiding this comment.
Setting CMAKE_INSTALL_PREFIX in this way could lock installation to /opt/jderobot, ignoring command line requests via -DCMAKE_INSTALL_PREFIX or cache values (breaking more in turn #485).
Checked in a Xenial lxc containter forcing variable output and checking cache values.
I'm looking for an alternative regarding this issue .
|
@aitormf Please check your PR branch for a possible solution for the lock problem. |
[issue JdeRobot#485] Set CMAKE_INSTALL_PREFIX only if default value is requested
|
Thanks @lr-morales for the solution |
Moved all installations to /opt/jderobot
now we need use following source commad instead of gazebo-setup:
Is needed try all components, in particular VisualStates (@reysam93) and ardrone_driver because These components have hardcoded paths and I had to modify the code.
visualStates installation is now done using cmakelists instead of setup.sh script
@fqez and @chanfr, can you verify this PR?
This PR fix #879 and #872