Skip to content
This repository has been archived by the owner on Feb 21, 2021. It is now read-only.

[Issue #792] Fix compilation warnings - some warnings addressed #886

Merged
merged 23 commits into from
Oct 24, 2017

Conversation

lr-morales
Copy link
Member

This PR should address some of the compilation warnings produced when building JdeRobot, mostly non-return (as best as could without changing function return type) and unsigned comparison warnings.

@aitormf
Copy link
Collaborator

aitormf commented Jul 28, 2017

all works for me

@fqez
Copy link
Member

fqez commented Jul 28, 2017

Nice job

@lr-morales are you planning on keep adressing warnings? Or should we merge this already?

Cheers!

@lr-morales
Copy link
Member Author

lr-morales commented Jul 28, 2017

I have located some more "easy-to-solve" warnings, we can wait them before merging. I can comment again when I finish or feel that solving more warnings would take long in order to merge the ones already cleared and checked.

@lr-morales lr-morales force-pushed the global/build/792-fix-warnings branch from f066d4f to 2be59b8 Compare July 29, 2017 08:39
@lr-morales
Copy link
Member Author

Hello,

this PR should be ready about the "easy-to-solve" warnings, the remaining warnings should be the ones pointed at the issue #792.
@fqez, @aitormf: I think these should be reviewed and merge first and then start addressing the remaining ones.

@aitormf
Copy link
Collaborator

aitormf commented Aug 2, 2017

It's all Ok for me, good job @lr-morales

@fqez fqez merged commit 0e6a18b into JdeRobot:master Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants