Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Safari "tabbing" doesn't work for non-searchable Selects #3291

Closed
theneva opened this issue Dec 18, 2018 · 4 comments · Fixed by #4634
Closed

iOS Safari "tabbing" doesn't work for non-searchable Selects #3291

theneva opened this issue Dec 18, 2018 · 4 comments · Fixed by #4634
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer issue/reviewed Issue has recently been reviewed (mid-2020)

Comments

@theneva
Copy link
Contributor

theneva commented Dec 18, 2018

iOS Safari displays a nifty little toolbar whenever an input element is focused, which lets you skip directly to the next (or previous) input on the page.

This works as expected for the plain Select:

Working demo

demo of working navigation to searchable select


Setting isSearchable={false} has the side effect of making the <input> rendered by <DummyInput> readonly, which removes it from the tab order in iOS Safari:

Broken demo

demo of broken navigation to non-searchable select


It's still in the tab order in desktop Safari, though, so… that's a thing that happens.

I tried working around this by avoiding the soft keyboard without the readonly attribute, but I couldn't do it, hence this issue.

@lauterry
Copy link

Hi

Have you manage to disabled the virtual keyboard with tab arrow when focusinf the input ?

Best regards

@theneva
Copy link
Contributor Author

theneva commented Feb 12, 2019

Hi @lauterry! Nope, we haven't been able to remove it. The whole searchable-by-default thing is great for user experience on desktop and pretty bad on mobile, which is why we've turned it off—but then it looks bad in iOS Safari…

We're considering migrating our selects to an alternative (looking at Downshift) to get control over this part of the implementation.

@lauterry
Copy link

@theneva Thanks for your input

@bladey bladey added the issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet label May 29, 2020
@bladey bladey added the issue/reviewed Issue has recently been reviewed (mid-2020) label Jun 17, 2020
@ebonow ebonow added issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer and removed issue/bug-unconfirmed Issues that describe a bug that hasn't been confirmed by a maintainer yet labels Dec 19, 2020
@ebonow
Copy link
Collaborator

ebonow commented Dec 19, 2020

Bug confirmed:
Tested this with demo example from react-select.com home page using iPhone Simulator, iOS v12.4:

When select was searchable, I was able to use the "tab" navigation arrow
When select was not searchable, I was not able to focus on the input.

I suspect that this indeed is related to the issue described above.

There is likely a workaround possible by rendering another focusable element within the select and adding an onFocus handler on it to focus on the input using refs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug-confirmed Issues about a bug that has been confirmed by a maintainer issue/reviewed Issue has recently been reviewed (mid-2020)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants