-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu does not follow component when scrolling #3734
Comments
A workaround for this is to block scrolling with |
@matiosfree Out of interest, why do you need a |
@benkindt |
@benkindt As @ranihorev pointed the workaround provided by you menuShouldBlockScroll={true} blocks scrolling within the menu. Mostly, we are using react-select with portals ( menuPortalTarget={document.body}) on modals and slideIns. Could you please let us know in which version of react-select the bug #3734 is going to resolve. |
@srinivasmerugu I'm not sure if I just wasn't aware of the mentioned issue or this once worked in an older version. |
@benkindt this issue is happening only when we use menuPortalTarget={document.body} on modals/slidens in order to have the portals inside react-select. Without portals in older/newer versions its just works fine on modals /slideins. |
Hey @benkindt Can you please let me know if this is going to include in next release as we would like to use the portaling inside the modals/slideIns without any scrolling issues. Thanks in Advance! |
We also want to deal with this issue. Menu dropdown is producing scroll inside of modal dialog so we are setting |
@srinivasmerugu I don't know if this will be fixed in a future release. |
@benkindt the workaround is good but it blocks menu scroll |
@srinivasmerugu Good news. I found this comment, which mentions that there was a bug introduced in v3.0.5. I tested it and the workaround is working in version 3.0.4.
|
@benkindt We are using 3.1.0 version and its latest features .Could you please let me know if there is any plan of reverting the code which caused this issue. |
@srinivasmerugu you can follow the link to the mentioned comment. This thread is about the scrolling bug in particular, you may ask it there. I'm using v3.0.4 as long as there is no progress |
|
Hello - Thanks for reporting this issue. This bug has been reported multiple times as per issue #4088. A new master issue #4088 has since been created to keep track this this bug. This new issue will exist as the source of truth going forward to investigate the issue, report findings, and implement a bug fix. We'll take into account all the details above while investigating. If you feel this issue has been wrongly closed as it isn't related to the new master issue #4088, please let us know and we'll take another look. Thank you! |
Hey guys. I found the issue when I'm adding these 2 props:
menuPosition="fixed" portalPlacement="auto"
Then I open the menu and start scrolling the main scroll (not the menu scroll).
The menu stays in the same place.
Ex.: https://codesandbox.io/s/react-codesandboxer-example-39q8c
I expect the menu to follow the main component.
PS. I'm using this Sekect in material-ui Dialog with long item list, that's why I need menuPosition="fixed" prop.
The text was updated successfully, but these errors were encountered: