Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-input-autosize v2.1.2 for guard against undefined window #2187

Merged
merged 1 commit into from
Dec 13, 2017

Conversation

sximba
Copy link
Contributor

@sximba sximba commented Nov 30, 2017

This fixes #2186

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.431% when pulling f6ddda8 on sximba:master into 75f3043 on JedWatson:master.

@JackieLs
Copy link

JackieLs commented Dec 1, 2017

When will you merge the branch?Cause I am crashinggggggg now....

@JedWatson
Copy link
Owner

Thanks for that @sximba, will have this out shortly

@JackieLs you should be able to get the latest version by running a clean install before this is released - the caret range will pick up the latest patch. If that's not happening, you may need to update your lockfile.

@JedWatson JedWatson merged commit 16d2b3c into JedWatson:master Dec 13, 2017
@faustlifes
Copy link

@JedWatson update please version of react-input-autosize from ^2.1.2 to ^2.2.1 at package.json. npm doesn't always fetch the latest version of react-input-autosize and this error could be repeated again.

@tbm216
Copy link

tbm216 commented Jan 26, 2018

Agree with @faustlife. react-select fails to render on the server with react-input-autosize v2.1.2.
react-input-autosize v2.2.1 does work.

@JedWatson please update package.json.
Thanks

@JackieLs
Copy link

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use react-input-autosize v2.1.2 for guard against undefined window
6 participants