Prefer more descriptive esm word instead of es #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @TrySound, Any chance you could separate this into two PRs -- one with the tidy up, and one with the proposed breaking change? |
|
I will, sure |
|
Awesome, thank you! |
Merged
|
I will rebase after that PR get merged |
jossmac
pushed a commit
that referenced
this pull request
Jul 10, 2018
Merged
es has different meanings. Some call it es5+ syntax or just es6. There is a precedent of using `es` for untranspiled code in [materia-ui](https://unpkg.com/@material-ui/core@1.0.0/es/). In this diff I propose to rename `es` to `esm` as a shorthand for ES Modules. `jsnext:main` is deprecated in rollup community (it came from rollup and dead in it) and shouldn't be used anymore. `module` is enabled by default like in webpack.
|
@TrySound thanks for the input to react-select 🙂 Thought quite a bit about this and on balance I'm happy to go with your suggestion. It's a breaking change for anyone including the On a related note, I've been thinking quite a bit on how we could optimise |
|
Sure, I could help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es has different meanings. Some call it es5+ syntax or just es6.
There is a precedent of using
esfor untranspiled code inmateria-ui.
In this diff I propose to rename
estoesmas a shorthand forES Modules.
jsnext:mainis deprecated in rollup community (it came from rollup anddead in it) and shouldn't be used anymore.
moduleis enabled bydefault like in webpack.