Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuickStart instructions to README. #123

Merged
merged 3 commits into from
Apr 8, 2017
Merged

Add QuickStart instructions to README. #123

merged 3 commits into from
Apr 8, 2017

Conversation

JeetShetty
Copy link
Owner

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.526% when pulling 8d7c6ab on quickstart into 88c13a0 on master.

README.md Outdated
python greenpithumb/greenpithumb.py \
--poll_interval 15 \
--photo_interval 240 \
--config_file "C:\GreenPiThumb\greenpithumb\config.ini" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they followed the install directions, they don't actually have to specify this and it's probably not an interesting parameter for most people. Suggest dropping from the example.

README.md Outdated
--config_file "C:\GreenPiThumb\greenpithumb\config.ini" \
--sleep_window "23:15-07:00" \
--sleep_window "14:30-15:45" \
--image_path "C:\GreenPiThumb\greenpithumb\images" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They'll be running this from the Pi, so it'll be Linux-style paths. Suggest just putting "images/"

README.md Outdated
--sleep_window "23:15-07:00" \
--sleep_window "14:30-15:45" \
--image_path "C:\GreenPiThumb\greenpithumb\images" \
--db_file "C:\GreenPiThumb\greenpithumb\greenpithumb.db"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the above, this is probably not interesting enough to give it visibility here. People should be okay with the default and if not they can run --help to figure out how to customize.

README.md Outdated

## QuickStart Instructions

Run greenpithumb/greenpithumb.py and supply command-line flags for poll_interval, photo_interval, config_file, sleep_window, image_path, and db_file. Example below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest something like "After running the installation steps above on your Pi, run GreenPiThumb with a command like the following"

README.md Outdated
Run greenpithumb/greenpithumb.py and supply command-line flags for poll_interval, photo_interval, config_file, sleep_window, image_path, and db_file. Example below.

```bash
python greenpithumb/greenpithumb.py \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be sudo python because they need root privileges for the hardware stuff.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 80.56% when pulling 77347c5 on quickstart into 88c13a0 on master.

Copy link
Collaborator

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
--photo_interval 240 \
--sleep_window "23:15-07:00" \
--sleep_window "14:30-15:45" \
--image_path "images/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add moisture_threshold too? I guess it's going to vary per system.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 80.454% when pulling 0554cd4 on quickstart into 88c13a0 on master.

@JeetShetty JeetShetty merged commit f885671 into master Apr 8, 2017
@JeetShetty JeetShetty deleted the quickstart branch April 8, 2017 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants