Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus relevant parts of popular websites after entering insert mode #56

Closed
ipod825 opened this issue Jun 1, 2020 · 6 comments
Closed
Labels
enhancement New feature or request mode-insert Issues related to insert mode

Comments

@ipod825
Copy link

ipod825 commented Jun 1, 2020

When opening a google doc page. Entering i brings me into insert mode. But after entering <Esc> and i again. Though it is shown that I am in insert mode, but I can't make any modifications to the document. I must click the document again to start editing. Possibly the focus is on some other element as when I pressing <Tab> several times, it gets to insert the tab into the document.

@Jelmerro Jelmerro added mode-insert Issues related to insert mode question Further information is requested labels Jun 1, 2020
@Jelmerro
Copy link
Owner

Jelmerro commented Jun 1, 2020

I would like to know what you mean by being out of focus. Is it that you are focused on the page somewhere, but need to tab through it to get back to where you wanted to be in the sheet? Or are you not focused on the page at all, and is the only way back a mouse click?

@ipod825
Copy link
Author

ipod825 commented Jun 1, 2020

Out of focus means the document edit area component is not in focus. And that the focus is in some other component in the page. I can press tab to enter the edit area component, but it's not easy as I can't seen which component is infocus now. So the easiest way to go back is by a mouse click.

@Jelmerro
Copy link
Owner

Jelmerro commented Jun 1, 2020

Okay I understand what you mean, but I do not think that this a bug or anything that can actually be "fixed". Let me explain why I think that.

If you enter insert mode by simply pressing i, at what location would you expect the focus to be? Currently it just puts the focus to the page, which is from my point of view exactly what you asked Vieb to do. If you wanted to focus a specific element, you could have used follow mode, <action.insertAtFirstInput> or <pointer.insertAtPosition> to do so. The help should explain these options as well.

If your issue is different from what I described, or you feel that Vieb could improve in this regard, please try to describe what exactly it is that you want to be changed about the entering insert mode.

@ipod825
Copy link
Author

ipod825 commented Jun 1, 2020

I see.
But I would say that for google doc/slide/sheet these kind of sites, we could have some optimization to focus the edit port by default. As these sites have tons of users and that such behavior is what most people would expect. If it doesn't work out of the box, most people would probably think Vieb is broken.

@Jelmerro Jelmerro added enhancement New feature or request help wanted Help wanted with this issue, so PRs are encouraged! and removed question Further information is requested labels Jun 1, 2020
@Jelmerro Jelmerro changed the title [Bug] Extra click needed to enter insert mode in google doc Focus relevant parts of popular websites after entering insert mode Jun 1, 2020
@ipod825
Copy link
Author

ipod825 commented Jun 1, 2020

FYI, qutebrowser does behave like this, though I am not sure if they do such kind of optimization or there's some fundamental difference between vieb and qutebrowser. One other thing is that qutebrowser also pass through 'j', 'k' keys in gmail.

@Jelmerro
Copy link
Owner

Jelmerro commented Apr 2, 2023

I have though about this for a while recently. I could not come up with a solution that would seem logical compared to having people choose the right location themselves with follow mode. It would also be a huge effort to figure out what the "relevant part" of a site is, especially because there are an almost infinite amount of sites, which all would need a "relevant location" to be found AND be kept up to date. Hence this effort seems way too big for something that can already be done by just selecting the location with follow mode. Combined with the lack of interest from other users over these last years, I would like to close this issue as won't fix and encourage users to use follow mode to select elements.

@Jelmerro Jelmerro closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2023
@Jelmerro Jelmerro removed the help wanted Help wanted with this issue, so PRs are encouraged! label Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mode-insert Issues related to insert mode
Projects
None yet
Development

No branches or pull requests

2 participants