Added optional "with-serde" feature that enables serde #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize and Deserialize code taken straight from https://serde.rs/deserialize-map.html Also updated the Edition, which won't affect dependencies.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 95.96% 95.85% -0.12%
==========================================
Files 1 1
Lines 124 193 +69
==========================================
+ Hits 119 185 +66
- Misses 5 8 +3
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize and Deserialize code taken straight from https://serde.rs/deserialize-map.html
Also updated the Edition, which won't affect dependencies.
NOTE: Currently I don't require
V: Defaultfor serialize, meaning that it is possible to have a DefaultHashMap that can serialize, but not de-serialize. How do you want to handle this? Just document it, or add the unnecessary trait restriction?