Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight improvement n.init #80

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Conversation

BertvanderVeen
Copy link
Collaborator

Apologies, but the improvement for n.init required a bit further fine tuning.

  • n.init.max should of course be < n.init (so, by default now at 10).
  • slightly more informative warning when n.init.max is reached
  • if a model would be accepted by the norm of the gradient, first check if the two gradient differ sufficiently, otherwise there is no point. This gives a slightly more strict convergence criteria for n.init.max - it would be possible to continue accepting models indefinitely otherwise.

I also uncommented the if(TMB)trace<-FALSE in the gllvm.R file, since this tracing can actually be useful in combination with n.init.

@JenniNiku JenniNiku merged commit 88e70ad into JenniNiku:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants