Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the type of the InboundEmail.Charsets property #466

Closed
Jericho opened this issue Sep 27, 2022 · 1 comment
Closed

Change the type of the InboundEmail.Charsets property #466

Jericho opened this issue Sep 27, 2022 · 1 comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Milestone

Comments

@Jericho
Copy link
Owner

Jericho commented Sep 27, 2022

Currently, the type of this property is KeyValuePair<string, Encoding>[] but the Encoding type is problematic. The main problem is that this type contains a ReadOnly<Span> property which the Json source generator cannot handle. This is not so bad in .NET 6 and prior frameworks because we can omit the InboundEmail class from the serialization context and let the Json serializer/deserializer fall back to reflection based serialization.

However, this fallback logic has been removed in .NET7 which means that we have to include InboundEmail in the serialization context. Therefore, the only solution is to remove the Encoding type and replace it with a simple string.

@Jericho Jericho added the Breaking Change This change causes backward compatibility issue(s) label Sep 27, 2022
@Jericho Jericho added this to the 0.94.0 milestone Sep 27, 2022
@Jericho
Copy link
Owner Author

Jericho commented Sep 30, 2022

🎉 This issue has been resolved in version 0.94.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Projects
None yet
Development

No branches or pull requests

1 participant