🩹 (radix-ui) NICE-97 reduced Anchor 🔗 [b]
#2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we call this directly there is an intermittent issue with `flex.props` which looks due to `parseJustifyValue` being called before it is created Though that ... really should not be a problem. But believe when this gets minified it can (or has). This is more information gathering.
JeromeFitz
changed the title
Flex; reduced Anchor [b]
What the heck cannot replicate locally But can replicate on Vercel
JeromeFitz
changed the title
Flex; reduced Anchor [b]Anchor 🔗 [b]
|
This pull request has been deployed to Vercel.
|
JeromeFitz
added
🥳️ LGTM
JeromeFitz
added a commit
that referenced
this pull request
Mar 27, 2024
Move `AnchorUnstyled` _to be_ `Anchor`.
----
No idea why this does not happen on localized build but does on hosting.
----
Current
```tsx
import { Flex } from '@radix-ui/themes'
```
- PRO: More legible; Less up-keep on `dist` changes
- CON: !tree-shaking
Preferred
```tsx
import { Flex } from '@radix-ui/themes/dist/esm/components/flex.js'
```
- PRO: Tree-shaking (`49 KiB` savings in unused JavaScript)
- CON: Have to call every component like this to take advantage
---
If we call this directly (`./dist/esm/components/flex.js`) there is an intermittent error triggered via routing.
This looks to be due to `flex.props` and the `parseJustifyValue` being created _after_ it is called.
- Which I do not htink _should_ be a problem, but perhaps with the way this is minified / prepared for production does matter for the order of the operations
This PR is more information gathering to be able to explain this issue and see if there is a fix,
or instead shelve and point to this as a discussion point for a later date.
----
**Update:** I actually think this is a routing issue, not a `radix-ui/themes` one. It just looks like it because it is triggering `404`. Not sure. If anything a new problem has come up 😆
♻️ (react) unnecessary calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
AnchorUnstyledto beAnchor.No idea why this does not happen on localized build but does on hosting.
Current
distchangesPreferred
49 KiBsavings in unused JavaScript)If we call this directly (
./dist/esm/components/flex.js) there is an intermittent error triggered via routing.This looks to be due to
flex.propsand theparseJustifyValuebeing created after it is called.This PR is more information gathering to be able to explain this issue and see if there is a fix,
or instead shelve and point to this as a discussion point for a later date.
Update: I actually think this is a routing issue, not a
radix-ui/themesone. It just looks like it because it is triggering404. Not sure. If anything a new problem has come up 😆