Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ NICE-99 simplified layout [b] #2528

Merged
merged 1 commit into from
Jun 3, 2024
Merged

✨ NICE-99 simplified layout [b] #2528

merged 1 commit into from
Jun 3, 2024

Conversation

JeromeFitz
Copy link
Owner

@JeromeFitz JeromeFitz commented Jun 2, 2024 •
edited
Loading

Well, what started as a "simplified layout" turned into a complete rewrite and of course since I did not really set out with a goal things are all over the place. 🤣

So started taking some control and breaking down some smaller tasks.

It is at the point where it is "shippable" but just means more tweaks down the line because there are still a lot of pages not migrated / updated for either layout.

Commits

🚧 NICE-99 move to zustand for temp mocks

🚧 NICE-99 more prep to move to a layout

🚧 NICE-99 more cta stuff

🚧 NICE-99 why did i think this would not take 4eva

🚧 NICE-99 body m-0 hack for dropdown

🚧 NICE-99 pixel perfect means... something i guess

🚧 NICE-99 px px px px px px 3vrywhr3

🚧 NICE-99 hidden good for aria|a11y

🚧 NICE-99 add icons, expand left col

🚚 NICE-99 start moving components for routing

🚧 NICE-99 continue to migrate to new layout

🚧 NICE-99 seems like a hack, but passes lighthouse

🚧 NICE-99 as always scope to the creep

🚧 NICE-107 cta z-index fix

🚧 NICE-103 books|music => currently/r|l-to

🚚 NICE-116 (next) redirects for currently

🚧 NICE-99 file renames and Box usage

🚧 NICE-106 mobile padding below container main

🚧 NICE-112 styled OL|UL|LI

🚨 NICE-99 pass lint 😮‍💨

🚧 NICE-101 pass event data

🚧 NICE-106 really fix padding this time

🚧 NICE-118 fix px, mobile first

🚧 NICE-118 mobile first

🚧 NICE-119 listening|reading move into "new" format for now

🚧 NICE-99 what timing this is being fixed...

🚧 NICE-99 more tailwind tweaks (pick a lane!)

🚧 NICE-99 pause for radix-ui circ

🐛 (radix-ui) NICE-120 circular deps

⬆️ (deps) @radix-ui/themes@3.0.5

⬆️ (deps) package upgrades...

📦️ (deps) clean up deps from peers

🚧 NICE-119 reduce currently complexity

⬆️ (deps) @jeromefitz/eslint-config@3.0.3

⬆️ (deps) sharp@0.33.4 (from 0.32.6 ...)

💄 NICE-119 tighten things up

🚧 NICE-99 more cleanup...

⬇️ (deps) sharp@0.32.6 (revert)

🚧 NICE-99 rework fonts a bit; sidebar border

⬆️ (deps) playwright, storybook, vercel/analytics...

⬆️ (deps) vercel/analytics|speed-insights

🚧 NICE-99 overcomplicated currently prep

⬆️ (deps) lightningcss@1.25.1

⬆️ pnpm@9.1.2

🚧 NICE-99 uh ... why did spotify do this

🚧 NICE-99 layout tweaks, gradient/blur

⬆️ (deps) react-wrap-balancer@1.1.1

🚧 NICE-99 useSWRInfinitePages 🔥 jf/ds

🏷️ NICE-99 ugh tis port is awful

🚧 NICE-99 hide cmdk, add skip nav

➕ (deps) clean-up storybook and root eslint

⬆️ (deps) storybook@8.1.4

🔒️ (next) https localhost

💩 NICE-99 hack for mouseOver on dropdown

💩 NICE-99 yup revert that onMouse stuff

🚧 NICE-99 smoothscroll section legend

♻️ NICE-99 no client component, use scrollMarginTop

⬆️ (deps) ts-jest

🚧 NICE-99 section side scroller

⬆️ (deps) storybook, framer-motion, types/node

⬆️ (deps) types/node;framer-motion

🚧 NICE-99 guess i need to write ocntent now

⬆️ (deps) types/node, ramda

♿️ NICE-99 lhci updates

@JeromeFitz JeromeFitz force-pushed the NICE-99 branch 5 times, most recently from ae606d0 to d823470 Compare June 3, 2024 00:52
@BotJerome
Copy link
Collaborator

This pull request has been deployed to Vercel.

Latest commit: dfb6d68
✅ Preview: https://jeromefitzgerald-hoenl0i3f-j-e-r-o-m-e.vercel.app
🔍 Inspect: https://vercel.com/j-e-r-o-m-e/jeromefitzgerald/9a3jLtx3BU9idda4ZXsqn17GNXjq

View Workflow Logs

@JeromeFitz
✨ NICE-99 simplified layout [skip ci]
25581bc 
🚧  NICE-99 move to zustand for temp mocks

🚧  NICE-99 more prep to move to a layout

🚧  NICE-99 more cta stuff

🚧  NICE-99 why did i think this would not take 4eva

🚧  NICE-99 body m-0 hack for dropdown

🚧  NICE-99 pixel perfect means... something i guess

🚧  NICE-99 px px px px px px 3vrywhr3

🚧  NICE-99 hidden good for aria|a11y

🚧  NICE-99 add icons, expand left col

🚚  NICE-99 start moving components for routing

🚧  NICE-99 continue to migrate to new layout

🚧  NICE-99 seems like a hack, but passes lighthouse

🚧  NICE-99 as always scope to the creep

🚧  NICE-107 cta z-index fix

🚧  NICE-103 books|music => currently/r|l-to

🚚  NICE-116 (next) redirects for currently

🚧  NICE-99 file renames and Box usage

🚧  NICE-106 mobile padding below container main

🚧  NICE-112 styled OL|UL|LI

🚨  NICE-99 pass lint 😮‍💨

🚧  NICE-101 pass event data

🚧  NICE-106 really fix padding this time

🚧  NICE-118 fix px, mobile first

🚧  NICE-118 mobile first

🚧  NICE-119 listening|reading move into "new" format for now

🚧  NICE-99 what timing this is being fixed...

🚧  NICE-99 more tailwind tweaks (pick a lane!)

🚧  NICE-99 pause for radix-ui circ

🐛  (radix-ui) NICE-120 circular deps

⬆️  (deps) @radix-ui/themes@3.0.5

⬆️  (deps) package upgrades...

```bash
○ dependencies
○ Package                                                    Current   Target            Workspace              URL
● @jeromefitz/eslint-config                                    3.0.1 ❯ 3.0.2             @jeromefitz/websites
❯ ● @jeromefitz/release-notes-generator                          2.0.6 ❯ 2.0.8             @jeromefitz/websites
● @types/lodash                                               4.17.0 ❯ 4.17.4            @jeromefitz/websites
● @types/node                                                20.12.8 ❯ 20.12.12          @jeromefitz/websites
● semantic-release                                            23.0.8 ❯ 23.1.1            @jeromefitz/websites
● framer-motion                                               11.1.7 ❯ 11.2.4            jerandky.com
○ unfetch                                                      4.2.0 ❯ 5.0.0             jerandky.com
● virtua                                                      0.30.4 ❯ 0.31.0            jeromefitzgerald.com
○ devDependencies
○ Package                                                    Current   Target            Workspace                       URL
● @mantine/hooks                                               7.9.0 ❯ 7.9.2             @jeromefitz/ds
● @types/react                                                18.3.1 ❯ 18.3.2            @jeromefitz/ds
● @testing-library/react                                      15.0.6 ❯ 15.0.7            @jeromefitz/jest-config
● zod                                                         3.23.6 ❯ 3.23.8            @jeromefitz/next-config
● @playwright/test                                            1.43.1 ❯ 1.44.0            @jeromefitz/playwright-config
● @upstash/redis                                              1.30.0 ❯ 1.31.1            @jeromefitz/shared
● @storybook/addon-a11y                                        8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/addon-essentials                                  8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/addon-interactions                                8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/addon-links                                       8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/addon-styling                                     1.3.7 ❯ 1.3.7             @jeromefitz/storybook-config
● @storybook/addon-viewport                                    8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/blocks                                            8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/jest                                              0.2.3 ❯ 0.2.3             @jeromefitz/storybook-config
● @storybook/manager-api                                       8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/nextjs                                            8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/react                                             8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● @storybook/testing-library                                   0.2.2 ❯ 0.2.2             @jeromefitz/storybook-config
● @storybook/theming                                           8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● storybook                                                    8.0.9 ❯ 8.1.1             @jeromefitz/storybook-config
● lightningcss                                                1.24.1 ❯ 1.25.0            @jeromefitz/tailwind-config
○ sharp                                                       0.32.6 ❯ 0.33.4            @jeromefitz/tailwind-config
● @types/ramda                                               0.29.12 ❯ 0.30.0            jerandky.com
```

📦️  (deps) clean up deps from peers

🚧  NICE-119 reduce currently complexity

⬆️  (deps) @jeromefitz/eslint-config@3.0.3

⬆️  (deps) sharp@0.33.4 (from 0.32.6 ...)

💄  NICE-119 tighten things up

🚧  NICE-99 more cleanup...

⬇️  (deps) sharp@0.32.6 (revert)

🚧  NICE-99 rework fonts a bit; sidebar border

⬆️  (deps) playwright, storybook, vercel/analytics...

```bash
@mantine/hooks
@types/react
ts-jest
@playwright/test
@upstash/redis
@vercel/analytics
@storybook/addon-a11y
@storybook/addon-essentials
@storybook/addon-interactions
@storybook/addon-links
@storybook/addon-styling
@storybook/addon-viewport
@storybook/blocks
@storybook/jest
@storybook/manager-api
@storybook/nextjs
@storybook/react
@storybook/testing-library
@storybook/theming
storybook
framer-motion
```

⬆️  (deps) vercel/analytics|speed-insights

🚧  NICE-99 overcomplicated currently prep

⬆️  (deps) lightningcss@1.25.1

⬆️  pnpm@9.1.2

🚧  NICE-99 uh ... why did spotify do this

🚧  NICE-99 layout tweaks, gradient/blur

⬆️  (deps) react-wrap-balancer@1.1.1

🚧  NICE-99 useSWRInfinitePages 🔥 jf/ds

🏷️  NICE-99 ugh tis port is awful

🚧  NICE-99 hide cmdk, add skip nav

➕  (deps) clean-up storybook and root eslint

⬆️  (deps) storybook@8.1.4

🔒️  (next) https localhost

💩  NICE-99 hack for mouseOver on dropdown

💩  NICE-99 yup revert that onMouse stuff

🚧  NICE-99 smoothscroll section legend

♻️  NICE-99 no client component, use scrollMarginTop

⬆️  (deps) ts-jest

🚧  NICE-99 section side scroller

⬆️  (deps) storybook, framer-motion, types/node

⬆️  (deps) types/node;framer-motion

🚧  NICE-99 guess i need to write ocntent now

⬆️  (deps) types/node, ramda

♿️  NICE-99 lhci updates

♿️  🙈 skip-link 💩 ugh, spend more time later

ugh 98

🧪 (e2e) update

♿ back to 1

👷  NICE-99 set back to main 🙈 about [skip ci]
@JeromeFitz JeromeFitz added the 🥳️ LGTM Automerge: Let's Get This Merged label Jun 3, 2024
@kodiakhq kodiakhq bot merged commit d36bb21 into main Jun 3, 2024
1 check passed
@kodiakhq kodiakhq bot deleted the NICE-99 branch June 3, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeromeFitz @BotJerome