Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow version 2.x of oauth dependency #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrochkind
Copy link

@jrochkind jrochkind commented Dec 19, 2022

Closes #96

Note oauth 1.x is still allowed by gemspec, just expanded to allow 2.x too. OAuth release notes expect no problems from 2.x for most uses.

You have installed oauth2 version 1.4.11, which is EOL.
No further support is anticipated for the 1.4.x series.

OAuth2 version 2 is released.
There are BREAKING changes, but most will not encounter them, and upgrading should be easy!

We have made two other major migrations:
1. master branch renamed to main
2. Github has been replaced with Gitlab

Please see:
• https://gitlab.com/oauth-xx/oauth2#what-is-new-for-v20
• https://gitlab.com/oauth-xx/oauth2/-/blob/main/CHANGELOG.md
• https://groups.google.com/g/oauth-ruby/c/QA_dtrXWXaE

Please upgrade, report issues, and support the project! Thanks, |7eter l-|. l3oling

@jrochkind
Copy link
Author

Huh, Travis actually is running -- which really surprised me as travis had ended their support for open source.

The build seems to be failing on VCR cassette mis-matches. There are instructions for generating VCR casettes in README, but I'm not sure i have time/energy to try it. Would anyone else like to help?

I'm also not sure why the tests are passing for me locally! I did have some tries running tests where I had similar VCR cassette failures... but without changing anything but just running again, it started passing, not sure why.

@jrochkind
Copy link
Author

Hm, I tried to regenerate vcr casettes with an dropbox oauth token, but ran into this error i'm not sure how to solve:

DropboxApi::Errors::ExpiredAccessTokenError: missing_scope/..
/Users/jrochkind/code/dropbox_api/lib/dropbox_api/endpoints/base.rb:41:in `process_response'
/Users/jrochkind/code/dropbox_api/lib/dropbox_api/endpoints/base.rb:17:in `perform_request'

@Laykou
Copy link

Laykou commented Jan 17, 2023

@Jesus Do you please know how this could be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to 2.x of oauth gem as dependency?
2 participants