-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: language header #3147
Closed
scottkelso
wants to merge
4
commits into
feature/24-05-JK-feat-resources-hub-search
from
24-05-JK-feat-language-header
Closed
feat: language header #3147
scottkelso
wants to merge
4
commits into
feature/24-05-JK-feat-resources-hub-search
from
24-05-JK-feat-language-header
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to fix spacing, need to ensure all urls are setup correctly, need to fix tests
scottkelso
added
priority: 2day
effort: 3
type: feat
Brand new functionality, features, pages, workflows, endpoints, etc.
labels
Jul 29, 2024
The latest updates on your projects.
|
The latest updates on your projects.
|
The latest updates on your projects.
|
scottkelso
changed the base branch from
main
to
feature/24-05-JK-feat-resources-hub-search
July 29, 2024 20:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: 3
priority: 2day
type: feat
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
We need a way to select language
Link to Basecamp Todo
Solution
Re-add the HeaderAndLanguageFilter
External Changes
n/a
Additional information
How to test
Behaviour should match journeys admin