Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display title and footer text #3333

Merged
merged 13 commits into from
Sep 4, 2024
Merged

Conversation

levi-zustiak
Copy link
Contributor

Description

Issue

Provide a brief summary of why this task is needed

Link to Basecamp Todo

Solution

  • Added DisplayTitle component
  • Added DisplayTitle to Footer
  • Updated StepFooter to use journey displayTitle

@levi-zustiak levi-zustiak added effort: 2 priority: soon type: feat Brand new functionality, features, pages, workflows, endpoints, etc. labels Aug 28, 2024
@levi-zustiak levi-zustiak added this to the 2024 - 06 Cycle milestone Aug 28, 2024
@levi-zustiak levi-zustiak self-assigned this Aug 28, 2024
Copy link

linear bot commented Aug 28, 2024

ENG-656 Footer Text

@levi-zustiak levi-zustiak changed the base branch from main to lz/eng-652-reactions-settings August 29, 2024 18:56
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Warnings
⚠️ Is this PR related to a Basecamp issue? If so link it via the PR description - https://3.basecamp.com/3105655/buckets/:projectId/todos/:todoId

Generated by 🚫 dangerJS against 8866641

Base automatically changed from lz/eng-652-reactions-settings to main August 30, 2024 00:52
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin August 30, 2024 01:43 Inactive
Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready Visit Preview Wed Sep 4 02:33:05 UTC 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready Visit Preview Wed Sep 4 02:34:11 UTC 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Wed Sep 4 02:33:34 UTC 2024

Copy link

I see you added the "on stage" label, I'll get this merged to the stage branch!

Copy link

Merge conflict attempting to merge this into stage. Please fix manually.

@github-actions github-actions bot temporarily deployed to Preview - videos-admin September 4, 2024 02:30 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin September 4, 2024 02:30 Inactive
@levi-zustiak levi-zustiak added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 6ce5a68 Sep 4, 2024
23 checks passed
@levi-zustiak levi-zustiak deleted the lz/eng-656-footer-text branch September 4, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 on stage priority: soon type: feat Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants