-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display title and footer text #3333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levi-zustiak
added
effort: 2
priority: soon
type: feat
Brand new functionality, features, pages, workflows, endpoints, etc.
labels
Aug 28, 2024
levi-zustiak
changed the base branch from
main
to
lz/eng-652-reactions-settings
August 29, 2024 18:56
levi-zustiak
force-pushed
the
lz/eng-652-reactions-settings
branch
from
August 29, 2024 18:57
539cbdc
to
425a43a
Compare
levi-zustiak
force-pushed
the
lz/eng-656-footer-text
branch
from
August 29, 2024 19:05
1706fdd
to
79f6ca0
Compare
levi-zustiak
force-pushed
the
lz/eng-656-footer-text
branch
from
August 30, 2024 01:42
79f6ca0
to
f972199
Compare
The latest updates on your projects.
|
The latest updates on your projects.
|
The latest updates on your projects.
|
github-actions
bot
temporarily deployed
to
Preview - journeys-admin
September 3, 2024 22:02
Inactive
levi-zustiak
force-pushed
the
lz/eng-656-footer-text
branch
from
September 3, 2024 22:27
0415376
to
2e03d83
Compare
github-actions
bot
temporarily deployed
to
Preview - journeys-admin
September 3, 2024 22:28
Inactive
github-actions
bot
temporarily deployed
to
Preview - journeys-admin
September 3, 2024 22:36
Inactive
csiyang
approved these changes
Sep 4, 2024
I see you added the "on stage" label, I'll get this merged to the stage branch! |
Merge conflict attempting to merge this into stage. Please fix manually. |
github-actions
bot
temporarily deployed
to
Preview - journeys-admin
September 4, 2024 02:30
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: 2
on stage
priority: soon
type: feat
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Provide a brief summary of why this task is needed
Link to Basecamp Todo
Solution
DisplayTitle
componentDisplayTitle
toFooter
StepFooter
to use journeydisplayTitle