-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: language selection and folder structure #3345
Merged
GeronimoJohn
merged 3 commits into
feature/24-06-JK-feat-language-filter
from
johngeronimo/eng-745-language-selection-clean-up
Sep 1, 2024
Merged
fix: language selection and folder structure #3345
GeronimoJohn
merged 3 commits into
feature/24-06-JK-feat-language-filter
from
johngeronimo/eng-745-language-selection-clean-up
Sep 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeronimoJohn
added
effort: 2
type: fix
Iterations on existing features or infrastructure.
priority: soon
labels
Aug 30, 2024
The latest updates on your projects.
|
The latest updates on your projects.
|
The latest updates on your projects.
|
scottkelso
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashing!
GeronimoJohn
merged commit Sep 1, 2024
4de8a33
into
feature/24-06-JK-feat-language-filter
20 of 22 checks passed
GeronimoJohn
deleted the
johngeronimo/eng-745-language-selection-clean-up
branch
September 1, 2024 22:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a language highlights it in all of the other continents, to make the experience nicer we are to only select the language within that continent and disable the rest.