Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language selection and folder structure #3345

Conversation

GeronimoJohn
Copy link
Contributor

Selecting a language highlights it in all of the other continents, to make the experience nicer we are to only select the language within that continent and disable the rest.

@GeronimoJohn GeronimoJohn added effort: 2 type: fix Iterations on existing features or infrastructure. priority: soon labels Aug 30, 2024
@GeronimoJohn GeronimoJohn added this to the 2024 - 06 Cycle milestone Aug 30, 2024
@GeronimoJohn GeronimoJohn self-assigned this Aug 30, 2024
Copy link

linear bot commented Aug 30, 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

Warnings
⚠️ Is this PR related to a Basecamp issue? If so link it via the PR description - https://3.basecamp.com/3105655/buckets/:projectId/todos/:todoId

Generated by 🚫 dangerJS against 69ed327

Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready Visit Preview Fri Aug 30 05:49:01 UTC 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready Visit Preview Fri Aug 30 05:49:38 UTC 2024

Copy link
Contributor

github-actions bot commented Aug 30, 2024

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready Visit Preview Fri Aug 30 05:50:01 UTC 2024

@GeronimoJohn GeronimoJohn marked this pull request as ready for review August 30, 2024 05:45
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin August 30, 2024 05:46 Inactive
Copy link
Contributor

@scottkelso scottkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashing!

@GeronimoJohn GeronimoJohn merged commit 4de8a33 into feature/24-06-JK-feat-language-filter Sep 1, 2024
20 of 22 checks passed
@GeronimoJohn GeronimoJohn deleted the johngeronimo/eng-745-language-selection-clean-up branch September 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 2 priority: soon type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants