chore!: EXPOSED-239 Set preserveKeywordCasing flag to true by default #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior will now be that keyword identifiers retain their user-defined case sensitivity after getting quotations. The flag still exists, so users have the option to now opt-out if they still have not altered their identifier or quotation habits.
Fix hardcoded test for H2 column metadata.
bog-walk
force-pushed
the
bog-walk/change-keyword-default
branch
from
33a2796
to
0a7f803
Compare
e5l
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opt-in flag
preserveKeywordCasingwas introduced 3 versions ago (PR #1841 ).This PR sets the goal behavior (that keywords retain user-defined casing before being quoted) to
trueby default.The flag temporarily remains in the event that users want to opt-out of the now default behavior by setting it to
false.Tests have been refactored to account for new behavior.