Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EXPOSED-384 CurrentTimestamp cannot be used with OffsetDateTimeColumnType #2081

Merged
merged 2 commits into from
May 14, 2024
Merged

fix: EXPOSED-384 CurrentTimestamp cannot be used with OffsetDateTimeColumnType #2081

merged 2 commits into from
May 14, 2024

Commits on May 13, 2024

  1. fix: EXPOSED-384 CurrentTimestamp cannot be used with OffsetDateTimeC… 

    …olumnType

Since the 0.50.0 column type safety changes, CurrentTimestamp is no longer a class,
but an object, and it no longer returns type T, but Instant.

So its previous use as a default expression with a timezone compatible column is
no longer possible, as even changing to a singleton still required OffsetDateTime
as the return type.

This introduces a new object CurrentTimestampWithTimeZone for this specific use
to both modules exposed-java-time and exposed-kotlin-datetime.

Rather than repeating the same query builder logic, the 3 CurrentX objects now
extend from a base sealed class.
    @bog-walk
    bog-walk committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3382562 View commit details
    Browse the repository at this point in the history

  2. fix: EXPOSED-384 CurrentTimestamp cannot be used with OffsetDateTimeC… 

    …olumnType

Fix type in test
    @bog-walk
    bog-walk committed May 13, 2024
    Configuration menu
    Copy the full SHA
    99ca9c1 View commit details
    Browse the repository at this point in the history