Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fixup failed target names from BEP in bazel 6+ #402

Merged
merged 1 commit into from May 10, 2023

Conversation

steveniemitz
Copy link
Contributor

Target names in BEP in bazel 6 aren't prefixed with @, which causes a mismatch in comparing the failed targets with project targets.

Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, please update the changelog

i have also another thing to u: we were thinking that this is not the best place for bloop support - we dont know bloop well (so it's difficult to maintain it), and it actually doesnt use that much from our codebase - the bazel-bsp server doesnt even exist in the bloop mode;

since bazel-bsp can be used as a maven dependency, we have 2 propositions:

  • move it to a completely separate repo (not under jetbrains)
  • move it to the bloop itself

what do u think about it?

@steveniemitz
Copy link
Contributor Author

move it to a completely separate repo (not under jetbrains)

I could get behind this. Agreed its not really sharing much from bazel-bsp that couldn't be just exposed as APIs.

@abrams27
Copy link
Member

abrams27 commented May 9, 2023

perfect, then we will deprecate it in the following release, we are planning to release 3.0 with breaking changes around bsp notifications and project view in next ~2 months

can i merge this pr?

@steveniemitz
Copy link
Contributor Author

yeah this is good to merge. It looks like the google-format failure was unrelated to this change.

Deprecation for 3.0 seems fine to me, I'll figure out a better place for it.

@abrams27 abrams27 merged commit 3a60ce1 into JetBrains:master May 10, 2023
14 of 15 checks passed
@abrams27
Copy link
Member

fyi: we are planning to do the 3.0 release next week (or the following one) - it will also remove bloop from bazel-bsp

cc @lukaszwawrzyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants