Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

[fix] set uncaught execution handlers in executor services #425

Conversation

tpasternak
Copy link
Contributor

Otherwise, an executor service could crash (for example due to OutOfMemory exception) without calling process exit, so as a result the process would hang.

@tpasternak tpasternak force-pushed the set-uncaught-exception-handlers-in-executor-services branch 2 times, most recently from 9abae0e to d7a1838 Compare June 6, 2023 13:13
@tpasternak tpasternak marked this pull request as ready for review June 6, 2023 13:13
@tpasternak tpasternak requested a review from abrams27 June 6, 2023 13:13
@tpasternak tpasternak force-pushed the set-uncaught-exception-handlers-in-executor-services branch from d7a1838 to 4c32936 Compare June 6, 2023 13:22
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! dont forget about the changelog

@abrams27 abrams27 changed the title Set uncaught execution handlers in executor services [fix] set uncaught execution handlers in executor services Jun 6, 2023
…ooled threads

Set uncaught execution handlers in executor services

Otherwise, an executor service could crash (for example due to OutOfMemory exception) without
calling process exit, so as a result the process would hang.
@tpasternak tpasternak force-pushed the set-uncaught-exception-handlers-in-executor-services branch from 4c32936 to a9914bf Compare June 6, 2023 13:41
@tpasternak tpasternak requested a review from abrams27 June 6, 2023 13:42
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@abrams27 abrams27 merged commit 8dfade9 into JetBrains:master Jun 6, 2023
@tpasternak tpasternak deleted the set-uncaught-exception-handlers-in-executor-services branch June 6, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants