This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[performance] Do not hold all output files of the project in memory a… #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpasternak
force-pushed
the
do-not-store-all-file-paths-in-memory
branch
4 times, most recently
from
1b6863e
to
412000c
Compare
tpasternak
force-pushed
the
do-not-store-all-file-paths-in-memory
branch
from
412000c
to
7b15c3f
Compare
tpasternak
force-pushed
the
do-not-store-all-file-paths-in-memory
branch
4 times, most recently
from
1a5ccbf
to
f90fdda
Compare
…t once Previously, we've been catching all NamedSetOfFiles messages that came over BEP in BepOutput.fileSets data structure. This meant we stored *all* output file paths of the project there, while the only purpose of it was to retrieve *.bsp-info.textproto files. Since now, we filter-out all other file kinds.
tpasternak
force-pushed
the
do-not-store-all-file-paths-in-memory
branch
from
b51de50
to
e602133
Compare
abrams27
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t once
Previously, we've been catching all NamedSetOfFiles messages that came over BEP in BepOutput.fileSets data structure. This meant we stored all output file paths of the project there, while the only purpose of it was to retrieve *.bsp-info.textproto files.
Since now, we filter-out all other file kinds.