This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Update Android project #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igordmn
commented
Aug 25, 2023
igordmn
commented
- update versions
- update Gradle
- targetSdk in library projects is deprecated
- update versions - update Gradle - targetSdk in library projects is deprecated
eymar
approved these changes
Aug 25, 2023
igordmn
added a commit
to JetBrains/compose-multiplatform
that referenced
this pull request
Aug 25, 2023
- Update Gradle to 8.2.1 (for non-Android project as well) - Update AGP to 8.0.2 - add jvmToolchain for Android projects (it is required now) - removed targetSdk from shared modules (it is deprecated for com.android.library projects) - move "package" from manifset to "namespace " in Gradle (required by AGP) - rename android to androidTarget (android is deprecated in latest Kotlin) - update Android dependencies versions I checked - Android/iOS/web still work. HTML/IDE projects also work after updating Gradle. Works in the latest stable IDEA and Android Studio updated templates: JetBrains/compose-multiplatform-ios-android-template#21 JetBrains/compose-multiplatform-template#19 JetBrains/compose-multiplatform-desktop-template#8 JetBrains/compose-multiplatform-html-library-template#3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.