Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable image viewer checks on CI #3384

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Jul 20, 2023

Because:

  1. it uses experimental API, that was changed int 1.5.0-beta03 after 1.4.0
  2. we have a policy to use only release versions in the examples

Temporarily, will made a fix in support/1.5.0 branch

Because:
1. it uses experimental API, that was changed int 1.5.0-beta03 after 1.4.0
2. we have a policy to use only release versions in the examples

Temporarily, will made a fix in support/1.5.0 branch
@igordmn igordmn requested a review from Walingar July 20, 2023 17:10
@igordmn
Copy link
Collaborator Author

igordmn commented Jul 20, 2023

Merging to unblock CI build

@igordmn igordmn merged commit 336ba2c into master Jul 20, 2023
@igordmn igordmn deleted the igor.demin/fix-imageviewer branch July 20, 2023 17:10
igordmn added a commit that referenced this pull request Jul 20, 2023
It was reverted in #3384

HorizontalPager is experimental, and it is okay for it to have incompatible changes
igordmn added a commit that referenced this pull request Jul 24, 2023
The CI checks was disabled in #3384. Reenable them in support/1.5.0, which will be merged after the 1.5.0 release.
igordmn added a commit that referenced this pull request Jul 25, 2023
Because:
1. it uses experimental API, that was changed int 1.5.0-beta03 after 1.4.0
2. we have a policy to use only release versions in the examples

Temporarily, will made a fix in support/1.5.0 branch
AlexeyTsvetkov pushed a commit that referenced this pull request Aug 15, 2023
The CI checks was disabled in #3384. Reenable them in support/1.5.0, which will be merged after the 1.5.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant