Support kotlin 1.9.20-Beta2 #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Sep 22, 2023
| @@ -16,7 +16,8 @@ internal object ComposeCompilerCompatibility { | |||
| "1.9.0-RC" to "1.4.8-beta", | |||
| "1.9.0" to "1.5.1", | |||
| "1.9.10" to "1.5.2", | |||
| "1.9.20-Beta" to "1.5.2.1-Beta2" | |||
| "1.9.20-Beta" to "1.5.2.1-Beta2", | |||
| "1.9.20-Beta2" to "1.5.2.1-Beta3" | |||
There was a problem hiding this comment.
In the future, we should name compiler versions the same as we name main compose versions (-beta01, -beta02)
| @@ -16,7 +16,8 @@ internal object ComposeCompilerCompatibility { | |||
| "1.9.0-RC" to "1.4.8-beta", | |||
| "1.9.0" to "1.5.1", | |||
| "1.9.10" to "1.5.2", | |||
| "1.9.20-Beta" to "1.5.2.1-Beta2" | |||
| "1.9.20-Beta" to "1.5.2.1-Beta2", | |||
| "1.9.20-Beta2" to "1.5.2.1-Beta3" | |||
| ) | |||
|
|
|||
| fun compilerVersionFor(kotlinVersion: String): String { | |||
There was a problem hiding this comment.
We have a failed test. Does it fail before the change?
There was a problem hiding this comment.
I'll check.
This change doesn't affect the version of the plugin used in the tests. So it's likely a flaky test/environemnt.
eymar
added a commit
that referenced
this pull request
Sep 25, 2023
(cherry picked from commit 393cfdd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.