Mark all resources public API as experimental. #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And all public but only for generated code API as @InternalResourceApi
pjBooms
approved these changes
Jan 19, 2024
igordmn
reviewed
Jan 19, 2024
| @@ -5,6 +5,7 @@ import kotlinx.cinterop.usePinned | |||
| import platform.Foundation.NSFileManager | |||
| import platform.posix.memcpy | |||
|
|
|||
| @OptIn(ExperimentalResourceApi::class) | |||
| actual suspend fun readResourceBytes(path: String): ByteArray { | |||
There was a problem hiding this comment.
Do we need to mark these actuals with @InternalResourceApi as the expect is marked with it?
| @@ -5,6 +5,7 @@ import androidx.compose.runtime.remember | |||
| import androidx.compose.ui.platform.LocalContext | |||
| import androidx.compose.ui.text.font.* | |||
|
|
|||
| @ExperimentalResourceApi | |||
There was a problem hiding this comment.
MalformedXMLException isn't marked with it.
Also sealed class Resource, but marking it Experimental can be too much, not sure 🤔.
igordmn
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And all public but only for generated code API as @InternalResourceApi