Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex #725

Merged
merged 259 commits into from
Feb 5, 2024
Merged

Regex #725

merged 259 commits into from
Feb 5, 2024

Conversation

emanuelgestosa
Copy link
Contributor

No description provided.

@AlexPl292
Copy link
Member

Hi there! The change is huge and we'll try to release it slowly and carefully:

  • Firstly, we'll do 2.6.0 release (Planned on 31.10)
  • Then we merge the PR with the disabled regex
  • Release 2.7.0
  • Turn on new regex, make a few EAPs
  • Release 2.8.0 with the new regex enabled
  • After approx. 3 months, we'll get rid of the old engine and old classes.

Awesome work!

lippfi
lippfi approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@lippfi lippfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still no editor snapshots, but I guess it's not a major issue.
You've done a great job; thank you for this PR.

@emanuelgestosa @lippfi
adding comments to parser grammar
312787b
@emanuelgestosa @lippfi
regex very magic and very nomagic modes
7daee88
@emanuelgestosa @lippfi
lexer support for unicode characters
e22db74
@emanuelgestosa @lippfi
unicode chars in all lexer modes
1c9b76c
@emanuelgestosa @lippfi
support unicode in collections
918c564
@emanuelgestosa @lippfi
lexer fixing what chars are taken literally
8e12b9e
@emanuelgestosa @lippfi
adding some zero-width tokens
5ee2e24
@emanuelgestosa @lippfi
initial nfa definition
2487e54
@emanuelgestosa @lippfi
initial nfa
b7583bc
@emanuelgestosa @lippfi
nfa simulation uses VimEditor instead of String
e36ee0b
@emanuelgestosa @lippfi
skeleton for NFA testing
697b648
@emanuelgestosa @lippfi
implementing quantifiers
60988d0
@emanuelgestosa @lippfi
updating comments
978a1d0
@emanuelgestosa @lippfi
add nfa test for escaped character
e64c68c
@emanuelgestosa @lippfi
implementing grouping
6cfed73
@emanuelgestosa @lippfi
add test for empty group
a320ca2
@emanuelgestosa @lippfi
use IntRange for match range
b93b7e5
@emanuelgestosa @lippfi
VimMatchResult stores matched string value
b777112
@emanuelgestosa @lippfi
capture group submatch
3fd311f
@emanuelgestosa @lippfi
add test for updating capture group
20183c0
@emanuelgestosa @lippfi
fixing quantifiers
06e8c40
@emanuelgestosa @lippfi
more correct way of handling quantifiers
839ec05
@emanuelgestosa @lippfi
fix nfa looping in epsilon transitions
dc13db1
@emanuelgestosa @lippfi
adding comments
276709c
emanuelgestosa and others added 26 commits February 5, 2024 16:07
@emanuelgestosa @lippfi
use injector for IjVimSearchHelper calls
362b262
@emanuelgestosa @lippfi
deprecating most of SearchHelper
eed2fc1
@emanuelgestosa @lippfi
working on processSearchCommand
5890dfb
@emanuelgestosa @lippfi
working on kotlin implementation of SearchGroup class
b005eee
@emanuelgestosa @lippfi
creating new IjVimSearchGroup class
2a80a52
@emanuelgestosa @lippfi
moving seach methods back to VimSearchGroup base
597decd
@emanuelgestosa @lippfi
fixing nohlsearch command
871d28e
@emanuelgestosa @lippfi
fixing some error messages
6fe85c5
@emanuelgestosa @lippfi
marking classes as deprecated
4207fe0
@emanuelgestosa @lippfi
getting rid of usages of deprecated classes
1db848e
@emanuelgestosa @lippfi
adding comments and small refactors
0f05b52
@emanuelgestosa @lippfi
removing print
9ed2c34
@lippfi
Hide method and add Deprecated annotation
42b13d7
@lippfi
Simplify MarkMatchers
ed8c496
@lippfi
Fix StartOfWordMatcher & EndOfWordMatcher
21f8a11
@lippfi
Fix Keyword token
ff8deb9
@lippfi
Fix tests
778c5fa
@lippfi
Fix visual matching
071df35
@lippfi
Remove deprecated code
0a314cd
@lippfi
Better SelectionInfo implementation
e66624b
@lippfi
Minor improvements
0177eb2
@lippfi
Fix VisualAreaMatcher & TextRange
853cbbc
@lippfi
Move more tests to src
ab65ded
@lippfi
Fix compilation
1292723
@lippfi
Enable new regex engine by default
a54e90c
@lippfi
Support e flag for search
eeb4e85
@lippfi
Copy link
Contributor

lippfi commented Feb 5, 2024

Thank you for your hard work, Emanuel!
This PR will be merged and made available in IdeaVim beginning with the next EAP.
Apologies for the delay in merging. This is a substantial change and we were waiting for the right moment as we wanted to create a release dedicated solely to the new Regex.

@lippfi lippfi merged commit 63995e8 into master Feb 5, 2024
4 checks passed
@AlexPl292 AlexPl292 deleted the regex branch February 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippfi lippfi lippfi approved these changes

@AlexPl292 AlexPl292 Awaiting requested review from AlexPl292

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanuelgestosa @AlexPl292 @lippfi