Skip to content

Commit

Permalink
[starter] Remove CompareSettings since we don't use comparision in te…
Browse files Browse the repository at this point in the history
…sts and instead rely on IJ Perf notifications

GitOrigin-RevId: 5fcde909293efc6f460c8f982ffc04589aa02504
  • Loading branch information
MaXal authored and intellij-monorepo-bot committed Jun 27, 2024
1 parent afe96b6 commit 536ec2b
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package com.intellij.tools.ide.metrics.collector.starter.publishing

import com.intellij.ide.starter.models.IDEStartResult
import com.intellij.ide.starter.runner.IDERunContext
import com.intellij.tools.ide.metrics.collector.analysis.CompareSetting
import com.intellij.tools.ide.metrics.collector.metrics.PerformanceMetrics
import com.intellij.tools.ide.metrics.collector.starter.collector.StarterMetricsCollector
import com.intellij.tools.ide.util.common.PrintFailuresMode
Expand All @@ -20,7 +19,6 @@ import com.intellij.tools.ide.util.common.withRetryBlocking
*/
abstract class MetricsPublisher<T> {
protected val metricsCollectors: MutableList<StarterMetricsCollector> = mutableListOf()
protected var metricsComparisonConfiguration: Map<String, CompareSetting> = mutableMapOf()

protected abstract var publishAction: (IDEStartResult, List<PerformanceMetrics.Metric>) -> Unit

Expand All @@ -36,11 +34,6 @@ abstract class MetricsPublisher<T> {
return this.asTypeT()
}

fun setCompareSettingForMetrics(metricsNames: List<String>, compareSetting: CompareSetting): T {
this.metricsComparisonConfiguration = metricsNames.associateWith { compareSetting }
return this.asTypeT()
}

fun getCollectedMetrics(runContext: IDERunContext): List<PerformanceMetrics.Metric> = metricsCollectors.flatMap {
withRetryBlocking(
messageOnFailure = "Failure on metrics collection",
Expand Down

0 comments on commit 536ec2b

Please sign in to comment.