Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE sources are not attached if you use IU for compilation starting with 2023.2 #1490

Closed
Undin opened this issue Nov 12, 2023 · 7 comments
Closed

Comments

@Undin
Copy link
Contributor

Undin commented Nov 12, 2023

What happened?

Starting with 2023.2, if you use IU for compilation, development IDE doesn't show platform sources, only for LSP related code. As I can see, the source jar is just not attached for IU 2023.2. Probably it's because of attached lsp api sources.

IU 2023.1 IC 2023.2 IU 2023.2
IU-2023 1 IC-2023 2 IU-2023 2

It makes plugin development for IU much harder, especially taking into account that more and more code in the platform is written in Kotlin and IntelliJ IDEA doesn't show decompiled Kollin code for class files, so you neither can see implementation nor put breakpoint for debugging in Kotlin files

Relevant log output or stack trace

No response

Steps to reproduce

Open this repo in IDE and try navigating to any platform class, for example, DynamicBundle

Gradle IntelliJ Plugin version

1.16.0

Gradle version

8.4

Operating System

macOS

Link to build, i.e. failing GitHub Action job

No response

@Undin Undin added the bug label Nov 12, 2023
@YannCebron
Copy link
Member

Have you configured IDE as described here? https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#ide-configuration

@Undin
Copy link
Contributor Author

Undin commented Nov 13, 2023

@YannCebron yes, I have. All things are checked in IU 2023.2.3 with Java 17

@Undin
Copy link
Contributor Author

Undin commented Nov 13, 2023

BTW Gradle settings in 2023.3 don't contain Download sources for dependencies option

Screenshot 2023-11-13 at 11 34 25

@hsz
Copy link
Member

hsz commented Nov 29, 2023

With 2023.3, it was moved to Settings | Advanced Settings

See: https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#attaching-sources

@hsz hsz closed this as completed Nov 29, 2023
@hsz hsz added depends on IDEA and removed bug labels Nov 29, 2023
@Undin
Copy link
Contributor Author

Undin commented Nov 29, 2023

@hsz do I understand correctly that you checked exactly this setup and it is not reproducible for you?
Because it works for me neither in 2023.2 nor in 2023.3 with all necessary options enabled

@hsz
Copy link
Member

hsz commented Dec 4, 2023

Fixed with 1.16.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants