Enable stricter Gradle plugin validation #1257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Improves cacheability of plugin tasks.
Description
Related Issue
Addresses one of the points raised in #1134, specifically:
Closes #1258
Motivation and Context
This improves the state of Gradle incremental builds and also identifies tasks that are missing annotations that declare whether they're cacheable or not. Both of these improve build performance.
Changing the configuration of the
validatePlugins
task to use stricter checks will ensure this problem doesn't occur again as new tasks and properties are added.How Has This Been Tested
Ran
./gradlew validatePlugins
. I haven't done testing of the tasks though. The annotations need to be reviewed by someone who has detailed knowledge of each task before merging.Types of changes
Checklist