Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different IntelliJ versions #165

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Support different IntelliJ versions #165

merged 9 commits into from
Oct 11, 2023

Conversation

Walingar
Copy link
Collaborator

@Walingar Walingar commented Oct 10, 2023

This PR provides new modules ide-laf-bridge-232 and ide-laf-bridge-233 that will be used for platform specific parts that are changed during releases and cannot be used in common ide-laf-bridge.

ide-laf-bridge will depend on one of them depending on local property supported.ij.version

Publishing is also changed. Now all publications will have suffix ij-$version e.g. 0.7.1-ij-232. When we support 233 we will have 2 publications e.g. 0.7.3-ij-233 and 0.7.3-ij-232 for all jewel parts.
In future it is better to split publishing process and publish everything except ide-laf-bridge with version without suffix and separately publish ide-laf-bridge and ide-laf-bridge-platform-specific with suffix depending on other parts without suffix

@Walingar Walingar requested a review from lamba92 October 10, 2023 16:27
@Walingar Walingar changed the title nr/support-233 Support different IntelliJ versions Oct 10, 2023
@Walingar Walingar requested a review from rock3r October 10, 2023 16:33
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Walingar
Copy link
Collaborator Author

Walingar commented Oct 10, 2023

Discussed with @rock3r that I will fix it in this PR

In future it is better to split publishing process and publish everything except ide-laf-bridge with version without suffix and separately publish ide-laf-bridge and ide-laf-bridge-platform-specific with suffix depending on other parts without suffix

run: ./gradlew publishIdeMainPublicationsToSpaceRepository -Psupported.ij.version=${{ matrix.supported-ij-version }}
env:
MAVEN_SPACE_USERNAME: ${{secrets.MAVEN_SPACE_USERNAME}}
MAVEN_SPACE_PASSWORD: ${{secrets.MAVEN_SPACE_PASSWORD}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: here and in other files, make sure there is an empty line at EOF. There is a convenient setting at Settings | Editor | General that automates it:

image

rock3r and others added 2 commits October 11, 2023 10:49
@Walingar Walingar merged commit b6f1597 into main Oct 11, 2023
6 checks passed
@Walingar Walingar deleted the nr/support-233 branch October 11, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants