Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SVG loading exceptions and path patching issues in IJ 233 EAP 4 #191

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Handle SVG loading exceptions and path patching issues in IJ 233 EAP 4 #191

merged 6 commits into from
Oct 19, 2023

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Oct 19, 2023

Same as #188 but up-to-date compared to main.

@rock3r rock3r added the bug Something isn't working label Oct 19, 2023
@rock3r rock3r added this to the Milestone 8 — v0.8.0 milestone Oct 19, 2023
@rock3r rock3r requested a review from lamba92 October 19, 2023 10:33
@rock3r rock3r self-assigned this Oct 19, 2023
@rock3r rock3r mentioned this pull request Oct 19, 2023
Closed
devkanro
devkanro reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@devkanro devkanro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, but the rules about fallback may still need to be discussed

core/src/main/kotlin/org/jetbrains/jewel/painter/ResourcePainterProvider.kt Outdated Show resolved Hide resolved
core/src/main/kotlin/org/jetbrains/jewel/painter/ResourcePainterProvider.kt Outdated Show resolved Hide resolved
@rock3r
Make loading fallback consistent for all resource types
02b329b 
Also document the behaviour in the KDoc
@rock3r
Prevent icon loading from crashing
f6b785a 
Plus, some IDE sample code cleanup
devkanro
devkanro approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@devkanro devkanro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rock3r rock3r enabled auto-merge (squash) October 19, 2023 13:32
@rock3r rock3r merged commit 94a144f into main Oct 19, 2023
12 checks passed
@rock3r rock3r deleted the lamberto.basti/fix-233-eap-icon-loading-issue-v2 branch October 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamba92 lamba92 lamba92 approved these changes

@devkanro devkanro devkanro approved these changes

Assignees

@rock3r rock3r

Labels
bug Something isn't working
Projects
None yet
Milestone
Milestone 8 — v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rock3r @devkanro @lamba92