Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KT-30343 Make quarkus compiler plugin available #2421

Closed
wants to merge 1 commit into from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 20, 2019

Follow up of #2163

@geoand
Copy link
Contributor Author

geoand commented Jun 20, 2019

Would it be possible to include this in a 1.3.41 release if that happens?

@geoand
Copy link
Contributor Author

geoand commented Aug 22, 2019

Any news on this folks?

@Dufgui
Copy link

Dufgui commented Aug 24, 2019

I ping you to be more viewable. @yanex @abelkov

@yanex
Copy link
Member

yanex commented Oct 2, 2019

Hello @geoand and @Dufgui!
While we have out-of-the-box support for Spring, we decided we are not ready to support additional frameworks right in the Kotlin project. What do you think about making the Quarkus plugin as a community one? It seems it only needs to provide a couple of compiler arguments to kotlinc, so it should be possible even in the current Kotlin & Maven/Gradle plugins.

@geoand
Copy link
Contributor Author

geoand commented Oct 2, 2019

@yanex Hi!

I see, however #2163 was merged so it wouldn't it make sense to go all the way and add this as well?

@yanex
Copy link
Member

yanex commented Oct 4, 2019

Well, we hadn't discussed this team-wide until now. If you think that keeping 'quarkus' preset alone doesn't make sense, we can move the annotation list to the community plugin as well.
Please contact us if you need any help. I persontally don't have much expertize in Maven plugin development, but other people from the team might be able to help you.

@geoand
Copy link
Contributor Author

geoand commented Oct 4, 2019

I see. Thanks for the info. Hopefully we will get around to it soon and we need help we'll reach out :)

@jreznot
Copy link
Member

jreznot commented Oct 9, 2019

@geoand As far as I know, Micronaut projects with Kotlin are configured with:

<configuration>
  <compilerPlugins>
    <plugin>all-open</plugin>
    <plugin>no-arg</plugin>
    <plugin>jpa</plugin>
  </compilerPlugins>
  <pluginOptions>
    <option>all-open:annotation=io.micronaut.aop.Around</option>
  </pluginOptions>
</configuration>

Examples: https://github.com/jreznot/micronaut-microservices-poc/blob/master/documents-service/pom.xml#L232

@geoand
Copy link
Contributor Author

geoand commented Oct 9, 2019

@jreznot Thanks for the info. We are doing something similar in the generated kotlin projects. However I would like to make it even easier for users - just like the spring compiler plugin where the user doesn't have to specify anything extra, just that they want the spring "profile" and everything else is added magically :)

@yanex
Copy link
Member

yanex commented Oct 16, 2019

Unfortunately, I have to close the pull request as the team decided not to add more framework-specific wrappers on top of the all-open plugin.
@geoand, please ping me if you encounter any problems during the implementation of the community plugin.

@yanex yanex closed this Oct 16, 2019
@geoand
Copy link
Contributor Author

geoand commented Oct 16, 2019

@yanex I will let you know, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants