Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic] Add missing "newrelic_set_user_id" function definition #1639

Merged
merged 2 commits into from
May 28, 2024

Conversation

xserrat
Copy link

@xserrat xserrat commented May 10, 2024

Hi!

We've figured out that the New Relic function newrelic_set_user_id was missing in the stubs.

Here is the related documentation.

Thanks!

@isfedorov
Copy link
Contributor

@xserrat Thank you for the PR! Could you please make one more small change and update stubs map. Please read how to do it at https://github.com/JetBrains/phpstorm-stubs?tab=readme-ov-file#how-to-update-stub-map

@xserrat
Copy link
Author

xserrat commented May 23, 2024

Thanks for the feedback @isfedorov . I'm going to add it right now!

@xserrat
Copy link
Author

xserrat commented May 23, 2024

I've added it manually because running the script I get this error:

Fatal error: Uncaught Error: Failed opening required '/opt/project/phpstorm-stubs/tests/Tools/../../vendor/autoload.php' (include_path='.:/usr/local/lib/php') in /opt/project/phpstorm-stubs/tests/Tools/generate-stub-map on line 37

Error: Failed opening required '/opt/project/phpstorm-stubs/tests/Tools/../../vendor/autoload.php' (include_path='.:/usr/local/lib/php') in /opt/project/phpstorm-stubs/tests/Tools/generate-stub-map on line 37

Call Stack:
    0.0086     585104   1. {main}() /opt/project/phpstorm-stubs/tests/Tools/generate-stub-map:0
    2.2668     585680   2. JetBrains\PHPStormStub\{closure:/opt/project/phpstorm-stubs/tests/Tools/generate-stub-map:36-291}() /opt/project/phpstorm-stubs/tests/Tools/generate-stub-map:291

@isfedorov isfedorov merged commit 5d05b72 into JetBrains:master May 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants