Allow Editor templates for projects with UNITY_EDITOR define #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizenmatt
approved these changes
May 18, 2021
There was a problem hiding this comment.
I think this is too broad - since UNITY_EDITOR is defined for all projects that are open in the editor, this means we'll show editor templates in runtime code for packages and assembly definitions. But I think it's better than not showing them at all for these projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jetbrains.slack.com/archives/C53QFRZ7G/p1620924775194600
When we have asmdef with Editor
"includePlatforms": [
"Editor",
],
UNITY_EDITOR define is in the csproj
Otherwise - when asmdef either exсludes Editor or doesn't include it - UNITY_EDITOR define is not in the csproj
"excludePlatforms": [
"Editor"
]
Assembly-CSharp and Assembly-CSharp-firstpass contain UNITY_EDITOR define, however Editor api-s compilation would fail.
If Player projects generation is enabled - those Player projects would not contain UNITY_EDITOR define.