Pavel.sergeev/set skia m116 #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeevPavel
force-pushed
the
pavel.sergeev/set-skia-m116
branch
2 times, most recently
from
5d38bf4
to
010cad7
Compare
|
#809 - was merged to master, so this PR should pass all tests after a rebase. |
SergeevPavel
force-pushed
the
pavel.sergeev/set-skia-m116
branch
from
1f050e4
to
e870fcc
Compare
igordmn
approved these changes
Oct 5, 2023
igordmn
approved these changes
Oct 5, 2023
|
I think we can postpone, though can we publish the brunch version somewhere? I would like to try to experiment with new apis in Fleet |
|
@igordmn can we merge it now? |
|
Yes, let's merge |
SergeevPavel
force-pushed
the
pavel.sergeev/set-skia-m116
branch
from
e870fcc
to
f7dcf63
Compare
eymar
pushed a commit
that referenced
this pull request
Nov 3, 2023
* update bindings according to skia-m116 * we don't have `ubuntu` suffix in skia artifacts anymore * fix compilation on windows * ignore the test because it was failing before * fix windows compilation * avgCharWidth is 0f on windows (cherry picked from commit 4217f64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.