-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--devel produces a bunch of odd warnings #1405
Comments
I've also seen it happen that yay only outputs |
Same here |
Can also confirm on yay v10.1.1 |
My internet connection dropped and update was interrupted before this message. Maybe that is related. |
My internet is sometimes unstable, but this happens so consistently that I expect this to be unrelated to internet connectivity (I've never seen it not happen, iirc also on more stable networks). |
@rien333 can you share your gitconfig (blur out ids and signing keys if you prefer) but this error is generally connected to the command timing out (signal killed) or git unclean exit (128 due to auth issues or bad permissions from what I've seen, can happen if you have a command that turns all https to ssh on gitconfig) EDIT: before yay would always hide this git output but for debugging purposes it is now visible |
My
|
Entirely removing the yay build directory got rid of these warnings for me, as a workaround, though obviously that's not ideal. |
Encountering the sames issue I have tested to remove the yay cache directory ( |
So far all I can find is that the error is from It also makes sense because this happens when EDITSo I decided to drop a fake git into the path and turns out that one of my packages required authentication for git 😕 This is the command
Fortunately I don't use it anymore, so I just uninstalled it, and now the warning is gone |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been marked as unstale because it's still very much real. Thanks for your work stale bot. |
so quick, good job |
Yep, this happens if login is needed, for me it was EDIT: To track this you can run |
Instead of using BuildGitCmd and parsing the output, we can use the Go bindings to libgit2 instead. In this particular case this improves on Jguer#1405
Likely the git CLI exits with 128 since it isn't run on an interactive terminal as it expects. One could either force/fake that or ask for credentials on ones own and pass it to the CLI. Alternatively, long-term, one may transition to using the libgit2 Go bindings by Git2Go. Using these, this particular function is quite easy to implement, I did a PoC here: https://github.com/ljrk0/yay/tree/git2go Instead of weird exit codes this yields the far more nice error message:
And supplying a callback to ask for authentication within yay should be okay-ish to implement, if there's a demand. But I don't think it makes sense to introduce a dependency on Git2Go and libgit2 for just that function. I don't have much experience with Go and neither of these libraries so I likely won't have time porting these, even if @Jguer agrees that this'd be a good way forward. |
I got a lot of "signal: killed" and "exit status 128" after updating with the --devel switch on. I found that it related to the kde plasma -git packages I installed. Some of those PKGBUILD's had either outdated sources that led to redirects or error pages. It initially built the packages but their git repos were not recorded in the vcs.json or they were written there with bad repo links. these packages for example. So I don't think it's yay that's got the issue, it's how the PKGBUILDS are made. Still learning IT stuff and this is my first bug/issue report. Hope it made some sense and helps. :) |
I think earlier in the thread we had already established that it was a yay issue. (or, more specifically, related to the way yay and git work together)
If it was an issue with certain PKGBUILDs, then running e.g. |
I think yay just fails to find the data for a devel package, but it should print an appropriate warning instead of this cryptic message that it received a non-zero return code from git. |
#1543 should help diagnose the misbehaving package |
I have this error without using --devel |
I have this issue again for all devel packages with a GitHub remote. For instance: |
Affected Version
I've tried running
yay-git
, as well as the latest stable version (10.1.0-1)Describe the bug
Whenever I run
yay -Sy --devel
,yay
outputs a bunch-> signal: killed" messages
, that seemingly do nothing, but I'm also really not sure where they're coming from (see output below). Sometimes the list of messages is prefixed with-> exit status 128
. After these messages, I'm presented with the dialogue to upgrade-git
packages, and everything works as expected.To Reproduce
Not sure, this suddenly started to happen a week or two ago. It happens everytime I run
yay -Sy --devel
.Expected behavior
yay
doesn't output a bunch of seemingly meaningless/uninformative warnings/messages.Output
Let me know what other sort of info might be relevant.
The text was updated successfully, but these errors were encountered: