Fix ContinueTask user prompt for locales with uppercase yes #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yes/y strings have to be converted to lowercase to enable matching of the user input converted to lowercase. Otherwise, locales with uppercase yes/y strings (e.g., German: `Ja/J`) will never match.
|
Also fixes #1737 |
|
well spotted, that seems to be the issue indeed, thanks, I'll probably make a release soon, just unsure between making a patch only for this or a major including the new sort algorithm |
Jguer
requested changes
Mar 29, 2022
Jguer
approved these changes
Mar 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue outlined in #1667. May also fix #1717