perf(parser): cache nested tokens in Set to prevent deoptimization (#83)

JiLiZART · Dec 16, 2020 · cad0e9e · cad0e9e
1 parent 70ff2e6
commit cad0e9e
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/packages/bbob-parser/src/parse.js b/packages/bbob-parser/src/parse.js
@@ -49,23 +49,31 @@ const parse = (input, opts = {}) => {
 
   /**
    * Cache for nested tags checks
-   * @type {{}}
    */
-  const nestedTagsMap = {};
+  const nestedTagsMap = new Set();
 
+  /**
+   *
+   * @param token
+   * @returns {boolean}
+   */
   const isTokenNested = (token) => {
-    if (typeof nestedTagsMap[token.getValue()] === 'undefined') {
-      nestedTagsMap[token.getValue()] = tokenizer.isTokenNested(token);
+    const value = token.getValue();
+
+    if (!nestedTagsMap.has(value) && tokenizer.isTokenNested && tokenizer.isTokenNested(token)) {
+      nestedTagsMap.add(value);
+
+      return true;
     }
 
-    return nestedTagsMap[token.getValue()];
+    return nestedTagsMap.has(value);
   };
 
   /**
    * @param tagName
    * @returns {boolean}
    */
-  const isTagNested = (tagName) => !!nestedTagsMap[tagName];
+  const isTagNested = (tagName) => Boolean(nestedTagsMap.has(tagName));
 
   /**
    * @private