Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Phase 1 (#180) #9

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Conversation

JimClarke5
Copy link
Owner

  • Initial checkin

  • Initial checkin and sync with master

  • Initial checkin and sync with master

  • JavaDoc cleanup

  • Javadoc fixes

  • Change LossInterface to LossMetric.
    Fix JavaDoc,
    modify one line code block to include braces.

  • Removed hashmap for variables, they are not needed as the variables only live within a single instance of a Metric.

  • reformat code

  • Add tests for assertBroadcastable

  • Change type to resultType

  • Added V data type for sampleWeights so that it is not forced to be the same type as the return or internal variables,

  • change 'type' to 'resultType'

  • clean up mean and fix assert assertBroadcastable

  • fix error message

  • Change sampleWeights to have its own generic type

  • Add commment about invalid tests expecting IllegalArgumentExceptions

  • Add this exception instead of the more generic IllegalArgumentException when static shapes cannot boradcast.

  • change IllegalArgumentException to NotBroadcastableException.
    change hasValidNonscalarShape to canBroadcastNonscalarShapes
    change hasValidNonscalarShape to canBroadcastNonscalarShapes

  • reformat code

  • Fis=x Javadoc
    move the dynamic shapes and rank down to the dynamic section so they are created needlessly when static
    Fix if statement to check for unknown size and unknown dimensions

  • Fix Reduce to use boradcastWeights,
    renamed WeightBroadcastTest to AssertBroadcastableTest and added BroadcastWeightsTest

  • Added comment to count to indicate that it may be weighted.

  • Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,

  • Fixed based on various PR comments.

  • Deleted, no longer needed after change to Variable handling in Metrics.

  • Nicer error messages for mode-forbidden ops (Nicer error messages for mode-forbidden ops tensorflow/java#169)

  • start fobbiden ops checks

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • fix style

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • move checks to builder method

Signed-off-by: Ryan Nett rnett@calpoly.edu

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • runInit() method in session

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • add doInitialization() to Runner

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • fix javadoc

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • assume only graph or eager environments

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Remove doInit(), update javadocs

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • small fixes

Signed-off-by: Ryan Nett rnett@calpoly.edu

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Do codegen

Signed-off-by: Ryan Nett rnett@calpoly.edu

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Generate covariant types

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Do generation

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Update help text.

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Fixes

Signed-off-by: Ryan Nett rnett@calpoly.edu

Signed-off-by: Ryan Nett rnett@calpoly.edu

  • Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy

  • Fix SetOps to properly convert sparse tensor to dense tensor using tf.sparse.sparseToDense with the output of tf.sparse.denseToDenseSetOperation

  • Initial checkin

  • Initial checkin and sync with master

  • Initial checkin and sync with master

  • JavaDoc cleanup

  • Javadoc fixes

  • Change LossInterface to LossMetric.
    Fix JavaDoc,
    modify one line code block to include braces.

  • Removed hashmap for variables, they are not needed as the variables only live within a single instance of a Metric.

  • reformat code

  • Add tests for assertBroadcastable

  • Change type to resultType

  • Added V data type for sampleWeights so that it is not forced to be the same type as the return or internal variables,

  • change 'type' to 'resultType'

  • clean up mean and fix assert assertBroadcastable

  • fix error message

  • Change sampleWeights to have its own generic type

  • Add commment about invalid tests expecting IllegalArgumentExceptions

  • Add this exception instead of the more generic IllegalArgumentException when static shapes cannot boradcast.

  • change IllegalArgumentException to NotBroadcastableException.
    change hasValidNonscalarShape to canBroadcastNonscalarShapes
    change hasValidNonscalarShape to canBroadcastNonscalarShapes

  • reformat code

  • Fis=x Javadoc
    move the dynamic shapes and rank down to the dynamic section so they are created needlessly when static
    Fix if statement to check for unknown size and unknown dimensions

  • Fix Reduce to use boradcastWeights,
    renamed WeightBroadcastTest to AssertBroadcastableTest and added BroadcastWeightsTest

  • Added comment to count to indicate that it may be weighted.

  • Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,

  • Fixed based on various PR comments.

  • Deleted, no longer needed after change to Variable handling in Metrics.

  • Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy

  • Fix SetOps to properly convert sparse tensor to dense tensor using tf.sparse.sparseToDense with the output of tf.sparse.denseToDenseSetOperation

Co-authored-by: Ryan Nett rnett@calpoly.edu

* Initial checkin

* Initial checkin and sync with master

* Initial checkin and sync with master

* JavaDoc cleanup

* Javadoc fixes

* Change LossInterface to LossMetric.
Fix JavaDoc,
modify one line code block to include braces.

* Removed hashmap for variables, they are not needed as the variables only live within a single instance of a Metric.

* reformat code

* Add tests for assertBroadcastable

* Change type to resultType

* Added V data type for sampleWeights so that it is not forced to be the same type as the return or internal variables,

* change 'type' to 'resultType'

* clean up mean and fix assert assertBroadcastable

* fix error message

* Change sampleWeights to have its own generic type <S extends TNumber>

* Add commment about invalid tests expecting IllegalArgumentExceptions

* Add this exception instead of the more generic IllegalArgumentException when static shapes cannot boradcast.

* change IllegalArgumentException to NotBroadcastableException.
change hasValidNonscalarShape to canBroadcastNonscalarShapes
change hasValidNonscalarShape to canBroadcastNonscalarShapes

* reformat code

* Fis=x Javadoc
move the dynamic shapes and rank down to the dynamic section so they are created needlessly when static
Fix if statement to check for unknown size and unknown dimensions

* Fix Reduce to use boradcastWeights,
renamed WeightBroadcastTest to AssertBroadcastableTest and added BroadcastWeightsTest

* Added comment to count to indicate that it may be weighted.

* Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,

* Fixed based on various PR comments.

* Deleted, no longer needed after change to Variable handling in Metrics.

* Nicer error messages for mode-forbidden ops (#169)

* start fobbiden ops checks

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* fix style

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* move checks to builder method

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Initialization imprvements (#178)

* No-op on initAdd in eager mode

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* runInit() method in session

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* add doInitialization() to Runner

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* fix javadoc

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* assume only graph or eager environments

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Remove doInit(), update javadocs

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* small fixes

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Clairify tensorOf lifetime requirements (#190)

* Clairify tensorOf lifetime requirements

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Do codegen

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Remove extra generics from op generation (#193)

* Successfully remove extra type params, but it broke javadoc generation

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Generate covariant types

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Do generation

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Update help text.

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Fixes

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Add Java 11 support - Initial Phase (#185)

* Add profile for JDK11 and  Automatic-Module-Name to jars

* add maven.compiler.release=11

* Update manual ops for new codegen (#196)

Signed-off-by: Ryan Nett <rnett@calpoly.edu>

* Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy

* Fix SetOps to properly convert sparse tensor to dense tensor using tf.sparse.sparseToDense with the output of tf.sparse.denseToDenseSetOperation

* Initial checkin

* Initial checkin and sync with master

* Initial checkin and sync with master

* JavaDoc cleanup

* Javadoc fixes

* Change LossInterface to LossMetric.
Fix JavaDoc,
modify one line code block to include braces.

* Removed hashmap for variables, they are not needed as the variables only live within a single instance of a Metric.

* reformat code

* Add tests for assertBroadcastable

* Change type to resultType

* Added V data type for sampleWeights so that it is not forced to be the same type as the return or internal variables,

* change 'type' to 'resultType'

* clean up mean and fix assert assertBroadcastable

* fix error message

* Change sampleWeights to have its own generic type <S extends TNumber>

* Add commment about invalid tests expecting IllegalArgumentExceptions

* Add this exception instead of the more generic IllegalArgumentException when static shapes cannot boradcast.

* change IllegalArgumentException to NotBroadcastableException.
change hasValidNonscalarShape to canBroadcastNonscalarShapes
change hasValidNonscalarShape to canBroadcastNonscalarShapes

* reformat code

* Fis=x Javadoc
move the dynamic shapes and rank down to the dynamic section so they are created needlessly when static
Fix if statement to check for unknown size and unknown dimensions

* Fix Reduce to use boradcastWeights,
renamed WeightBroadcastTest to AssertBroadcastableTest and added BroadcastWeightsTest

* Added comment to count to indicate that it may be weighted.

* Added SetsOps and fixed AssertBroadcastable to use SetsOps methods,

* Fixed based on various PR comments.

* Deleted, no longer needed after change to Variable handling in Metrics.

* Fix Losses to use CHANNELS_FIRST/LAST for CategoricalCrossentropy

* Fix SetOps to properly convert sparse tensor to dense tensor using tf.sparse.sparseToDense with the output of tf.sparse.denseToDenseSetOperation

Co-authored-by: Ryan Nett <rnett@calpoly.edu>
@JimClarke5 JimClarke5 merged commit e0c9ed8 into JimClarke5:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant