Skip Invalid Rule Instead of Skipping All Remaining Candidate Rules #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a rule that has a predicate that is invalid, the Brain was skipping all remaining valid rules and reporting that no rule was found.
The above code was causing the rule engine to report that no match was found for small screens because the
foo
predicate was unknown to the engine. Instead of just ignoring that rule and falling back to the 2nd rule, it was saying no match was found.This fix will fallback to another candidate if it exists.
Note that Cocoapods 1.84 changed some project files when I ran pod install to set up the project. I can remove those changes if you'd like.