Refactor/add typescript #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial setup to get TS working - no changes to the source or deployed package yet
The detection tasks themselves are framework agnostic and since we plan to add a reporter for vitest opting to pull them out now makes sense.
Moving the detection and reporter specs into the jest config should make things simpler down the line as we add more reporters and don't want to add a ton of individual test tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first pass at the reporter (v1) was a quick one - getting the rough functionality in place that I knew had worked in previous iterations but starting from scratch.
With that behavior locked down, and the plan to add additional reporters for other test runners and frameworks, it made sense to do a basic typescript conversation and to abstract the shared "detection" logic.
With that in mind these changes:
Note: these changes aren't trying to lean hard into typing all-the-things. We might get there some day but for now basic types for reporters and detection is all we really want.