Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android:textAllCaps="true" causing icons not to display #124

Closed
fredszaq opened this issue Sep 22, 2015 · 5 comments
Closed

android:textAllCaps="true" causing icons not to display #124

fredszaq opened this issue Sep 22, 2015 · 5 comments

Comments

@fredszaq
Copy link

When adding android:textAllCaps="true" to a text view with icons, the icons are not displayed, a stroked square or nothing at all is displayed depending on the device used

@JoanZapata JoanZapata added the bug label Sep 26, 2015
@pinfrederic
Copy link

I need a fix too...

@JoanZapata
Copy link
Owner

It's actually a incompatibility between textAllCaps and spans.
See https://code.google.com/p/android/issues/detail?id=67509

I'm not sure what I should do about it :

  • Add a custom attribute allCaps usable on IconTextView, IconButton, etc.. instead of the original one. That would still break integration with other libraries that use Spans.
  • Allow you to easily uppercase your texts using textView.setText("hello {icon}".toUpperCase()) without breaking Iconify, by doing toLowerCase on icon keys internally. But that means icon keys would become case-independant, which is a (minor) breaking change.
  • Nothing

@fredszaq @pinfrederic WDYT?

@JoanZapata
Copy link
Owner

Well I think I'll take the third option after all, there's no good way to solve this.

@fredszaq
Copy link
Author

fredszaq commented Mar 1, 2016

It seems to be the best option yes !
Le 1 mars 2016 7:58 AM, "Joan Zapata" notifications@github.com a écrit :

Well I think I'll take the third option after all, there's no good way
to solve this.


Reply to this email directly or view it on GitHub
#124 (comment)
.

@jlhonora
Copy link

jlhonora commented Mar 1, 2016

Obviously this is your own project and I respect every decision you make about it, but when this bug bites you it bites you hard. At least for me this is a deal breaker.

Making icon keys case insensitive doesn't seem to be too bad an option in my opinion. Perhaps you can think about it one more time :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants