Stream Episode 11 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some tests related to FavoritesFragment but still have a non-sdk warning showing up, this makes the whenThereIsNoDataAndErrorOccursErrorViewStateIsShown() test flaky. Needs fix #29
Compile SDK was updated to android-p preview, support: 28.0.0-alpha1 and constraint to 1.1.0 #29
This way the consumer (ViewModel) gets the response from the same place the request is made, this prevents the akwardness it comes with requesting on a place and receiving on another
The user now gets a Requesting... message (might change the string) with the ability to cancel the request, in reality this request isn't canceled - If the sms was already sent, then we ignore the response - The UI renables the REQUEST ETA buttons (were previously disabled) - If an error occurs the user is notified This should give more control to the user, if the service is unresposive. #29
Moved all the extension functions to a separate packages to make it more clear where stuff is. #29”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.