Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta brede #111

Merged
merged 69 commits into from
Apr 30, 2019
Merged

Beta brede #111

merged 69 commits into from
Apr 30, 2019

Conversation

BredeFK
Copy link
Collaborator

@BredeFK BredeFK commented Apr 25, 2019

Changes

  • All new passwords has to at least 6 chars long
  • Teacher can send all students in course an email
  • Changed email address to csams.noreply@gmail.com with the same password
  • Added more logging events (42 in total)
    • Some logging events have functions, but don't get triggered yet (ex: groups)
  • Added front-end for admin to see all logs
  • Users have to confirm new email before it gets added to their profile
  • Converted logs to repository/service and removed all previous from model, same with FAQ
  • Removed the go get's from
  • Changed the text for forgotten password, new user and new email emails to what Christopher wanted
  • Changed the Activity in logs from string to int for easier use
  • Switched to services som places
  • Fixed join course through register link

I also edited logs and users_pending table

bredefk added 30 commits April 9, 2019 16:18
Copy link
Owner

@JohanAanesen JohanAanesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix services then k ❤️ 💯

@BredeFK BredeFK dismissed JohanAanesen’s stale review April 26, 2019 13:03

He said I could dismiss it after fixing the stuff commented

Copy link
Collaborator

@kongebra kongebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed one services usage.

Some relativly easy improvments can be made

webservice/route/route.go Outdated Show resolved Hide resolved
webservice/service/user.go Show resolved Hide resolved
webservice/template/admin/logs/index.tmpl Outdated Show resolved Hide resolved
webservice/template/admin/logs/index.tmpl Show resolved Hide resolved
webservice/template/admin/logs/index.tmpl Outdated Show resolved Hide resolved
@kongebra kongebra self-requested a review April 29, 2019 09:27
@BredeFK BredeFK added the feature New feature label Apr 29, 2019
@BredeFK BredeFK self-assigned this Apr 29, 2019
@JohanAanesen JohanAanesen merged commit 169d1a8 into master Apr 30, 2019
@BredeFK BredeFK deleted the beta-brede branch May 8, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants