Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review pooling #121

Merged
merged 61 commits into from
Apr 30, 2019
Merged

Review pooling #121

merged 61 commits into from
Apr 30, 2019

Conversation

JohanAanesen
Copy link
Owner

Key updates:

  • Removed scheduler service

  • Removed peer service

  • Updated docker-compose file for these changes and others

  • New peer review algoritm added

  • Users will now request a review to do, and receive it from the 'pool' of submissions that needs to be reviewed

  • Enabling and Disabling reviews button and stuff has been added

  • Added informational messages to users when doing things like updating password

  • Updated assignment page to be more dynamic and showing how many reviews you have received

  • Cleaned out most of the model files for database related functions that are already in /repository

  • Merged with master

Johan Aanesen added 30 commits April 9, 2019 16:53
removed schedulerservice and peerservice
d95f5be
updated docker-compose
3a047a9
removed last traces of scheduler and peerservice
8387eba
removed scheduler connection files
1c5b08c
removed scheduler updating and registering from admin_assignment.go
0985240
updated assignment setting with a 0 value for reviews
e775b34
disable button added, and now updating to null in db for review_id
a4d3555
updated create page aswell
0a68464
Merge branch 'master' of github.com:JohanAanesen/CSAMS into review-po…
88ca1e3 
…oling

merge
added pooling functionality backend
58b0bb6
added shuffle function as a util
895cd52
merge
b92ec9d
removed traces of auto validation
d928658
Peer Review button now active when peer reviewing is active
b501c8c
peer review and view reviews buttons are only active if the assignmen…
bcdfe11 
…t has peer review and deadline has passed
removed dick from comment
eca4611
review pooling works I think :)
2cc2e56
trying to fix why it won't update assignments anymore
24c9904
rolled back some files because updating assignment wasn't working any…
bcb9396 
…more, hopefully it will now
fixed 'go backs' typo
7c26673
assignment page dynamically shows you how many reviews you have to do…
b1f7fbb 
… now
buttons now removed after deadline is over
39a465c
fixed changing reviewers count to 'any' and small frontend bug
90c565d
fixed issue where simplemde wouldn't render because of a template com…
6d25781 
…parison error
fixed bug where 'any' reviewers or 0 would crash the see submissions …
1df9f7a 
…for admins
removed schedulerservice link
6616ac7
fixed issue with updating review_id on assignment, removed foreign key
4a2f387
changed naming in assignment tabs for reviews received
d15f025
added a error for reviews limit reached
e71bd36
made faulty message better :)
6b207d7
Johan Aanesen added 14 commits April 25, 2019 14:37
cleaned out model/course for unused functions and structs
3c27461
cleaned out model/review for unused functions
60a6030
cleaned out model/submission for unused functions and structs
5f896f8
cleared out model/user for functions and fixed other functions needin…
fc49c10 
…g to use the repository/user instead
cleared out model/userSubmission for unused functions
2291eb7
added password changed successfully message when changing password
7cabec3
changed review_enabled column to normal bool, not nullable
e21c371
added enable/disable functionality to create assignment
ec2dbbc
added turning on off reviews functionality to update page
15b6751
enabling/disabling peer review functionality now working for assignme…
a6e9c02 
…nts and updating
setting review deadline one month after deadline if it hasn't been se…
42d9b79 
…t when updating assignment
fixed small bug :)
4a94cf6
changed hasReview function to check reviewEnabled variable instead
750e429
merge errors fixed
9bb0017
BredeFK
BredeFK previously requested changes Apr 30, 2019
View reviewed changes
Copy link
Collaborator

@BredeFK BredeFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In manage students when changing a students password, it doesn't actually change the password
  • When successfully changing password on profile, the message that appears on the profile page, appears on homepage too if the user goes to homepage after changing

kongebra
kongebra approved these changes Apr 30, 2019
View reviewed changes
webservice/controller/admin_assignment.go
ErrorHandler(w, r, http.StatusBadRequest)
return
}
// Check that review deadline isn't before assignment deadline
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uneccecary removal of a penile object

changed session messages to use session.flashes instead, removed mess…
df6e0d3 
…ages part from all tmpl and added to base.tmpl
@JohanAanesen JohanAanesen merged commit 4009a0c into master Apr 30, 2019
@JohanAanesen
Copy link
Owner Author

Remove/convert deprecated database queries in model folder to service/repository

@JohanAanesen
Copy link
Owner Author

Users can ask for reviews, review-pooling

@JohanAanesen JohanAanesen deleted the review-pooling branch May 15, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BredeFK BredeFK BredeFK left review comments

@kongebra kongebra kongebra approved these changes

Assignees

@JohanAanesen JohanAanesen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohanAanesen @kongebra @BredeFK